Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

support fitting net #3137

Merged
merged 2 commits into from
Jan 12, 2024
Merged

Conversation

wanghan-iapcm
Copy link
Collaborator

  • also add doc string for the embedding net

Copy link

codecov bot commented Jan 12, 2024

Codecov Report

Attention: 2 lines in your changes are missing coverage. Please review.

Comparison is base (04f07ef) 76.11% compared to head (9f538e0) 76.15%.
Report is 1 commits behind head on devel.

Files Patch % Lines
source/api_cc/src/DeepPot.cc 84.61% 1 Missing and 1 partial ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##            devel    #3137      +/-   ##
==========================================
+ Coverage   76.11%   76.15%   +0.04%     
==========================================
  Files         252      252              
  Lines       25450    25343     -107     
  Branches     1598     1579      -19     
==========================================
- Hits        19370    19300      -70     
+ Misses       5141     5118      -23     
+ Partials      939      925      -14     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@wanghan-iapcm
Copy link
Collaborator Author

I find we could have written a uniform implementation of embedding and fitting networks across platforms. We only have to make the interface of MLPLayer uniform across platforms. @njzjz what do you think?

@njzjz
Copy link
Member

njzjz commented Jan 12, 2024

I find we could have written a uniform implementation of embedding and fitting networks across platforms. We only have to make the interface of MLPLayer uniform across platforms. @njzjz what do you think?

Agree

@wanghan-iapcm
Copy link
Collaborator Author

I find we could have written a uniform implementation of embedding and fitting networks across platforms. We only have to make the interface of MLPLayer uniform across platforms. @njzjz what do you think?

Agree

I will contribute in a future PR.

@wanghan-iapcm wanghan-iapcm merged commit 308f97e into deepmodeling:devel Jan 12, 2024
46 checks passed
@wanghan-iapcm wanghan-iapcm deleted the mdfmt-fit branch January 12, 2024 14:07
@wanghan-iapcm
Copy link
Collaborator Author

wanghan-iapcm commented Jan 12, 2024

I find we could have written a uniform implementation of embedding and fitting networks across platforms. We only have to make the interface of MLPLayer uniform across platforms. @njzjz what do you think?

Agree

The first step: #3138
The second step: #3141

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants