-
Notifications
You must be signed in to change notification settings - Fork 520
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
support fitting net #3137
support fitting net #3137
Conversation
wanghan-iapcm
commented
Jan 12, 2024
- also add doc string for the embedding net
Codecov ReportAttention:
Additional details and impacted files@@ Coverage Diff @@
## devel #3137 +/- ##
==========================================
+ Coverage 76.11% 76.15% +0.04%
==========================================
Files 252 252
Lines 25450 25343 -107
Branches 1598 1579 -19
==========================================
- Hits 19370 19300 -70
+ Misses 5141 5118 -23
+ Partials 939 925 -14 ☔ View full report in Codecov by Sentry. |
I find we could have written a uniform implementation of embedding and fitting networks across platforms. We only have to make the interface of MLPLayer uniform across platforms. @njzjz what do you think? |
Agree |
I will contribute in a future PR. |