Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

model format for the embedding net #3113

Merged
merged 6 commits into from
Jan 8, 2024
Merged

model format for the embedding net #3113

merged 6 commits into from
Jan 8, 2024

Conversation

wanghan-iapcm
Copy link
Collaborator

  • refact the dir structure for the model_format
  • change the input of NativeNet from List[NativeLayer] to the List[dict]

@wanghan-iapcm wanghan-iapcm requested a review from njzjz January 7, 2024 15:42
@github-actions github-actions bot added the Python label Jan 7, 2024
@codecov Codecov
Copy link

codecov bot commented Jan 7, 2024 •
edited
Loading

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (7b3c3c0) 75.87% compared to head (8550b68) 75.90%.

Additional details and impacted files 
@@            Coverage Diff             @@
##            devel    #3113      +/-   ##
==========================================
+ Coverage   75.87%   75.90%   +0.03%     
==========================================
  Files         247      248       +1     
  Lines       25117    25141      +24     
  Branches     1598     1598              
==========================================
+ Hits        19057    19084      +27     
+ Misses       5121     5118       -3     
  Partials      939      939

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@wanghan-iapcm @njzjz
Update deepmd_utils/model_format/network.py
7258e76 
Co-authored-by: Jinzhe Zeng <[email protected]>
Signed-off-by: Han Wang <[email protected]>
@wanghan-iapcm wanghan-iapcm requested a review from njzjz January 8, 2024 00:56
@wanghan-iapcm wanghan-iapcm enabled auto-merge (squash) January 8, 2024 02:56
@wanghan-iapcm wanghan-iapcm merged commit f181a30 into deepmodeling:devel Jan 8, 2024
46 checks passed
@wanghan-iapcm wanghan-iapcm deleted the mdfmt-embedding branch January 8, 2024 05:46
@njzjz njzjz mentioned this pull request Jan 8, 2024
Closed
37 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@njzjz njzjz njzjz approved these changes

Assignees
No one assigned
Labels
Python
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@wanghan-iapcm @njzjz