Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix native layer concat bug. #3112

Merged
merged 4 commits into from
Jan 5, 2024
Merged

Conversation

wanghan-iapcm
Copy link
Collaborator

add UT testing all input and output shapes

@wanghan-iapcm wanghan-iapcm requested a review from njzjz January 5, 2024 09:39
@github-actions github-actions bot added the Python label Jan 5, 2024
@njzjz
Copy link
Member

njzjz commented Jan 5, 2024

What is the expected input shape?

Copy link

codecov bot commented Jan 5, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (c4b7baa) 75.86% compared to head (449e7cc) 75.87%.

Additional details and impacted files
@@           Coverage Diff           @@
##            devel    #3112   +/-   ##
=======================================
  Coverage   75.86%   75.87%           
=======================================
  Files         247      247           
  Lines       25117    25117           
  Branches     1598     1598           
=======================================
+ Hits        19055    19057    +2     
+ Misses       5123     5121    -2     
  Partials      939      939           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@wanghan-iapcm
Copy link
Collaborator Author

wanghan-iapcm commented Jan 5, 2024

What is the expected input shape?

only the last dimension of the input is changed by the mlp. Do we add test of higher dimensional input like [xxx, yyy, ninp]?

@wanghan-iapcm wanghan-iapcm requested a review from njzjz January 5, 2024 11:13
@wanghan-iapcm
Copy link
Collaborator Author

What is the expected input shape?

only the last dimension of the input is changed by the mlp. Do we add test of higher dimensional input like [xxx, yyy, ninp]?

done

@njzjz njzjz merged commit 7b3c3c0 into deepmodeling:devel Jan 5, 2024
46 checks passed
@wanghan-iapcm wanghan-iapcm deleted the fix-model-fmt branch January 6, 2024 14:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants