Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

rm rcut from DeepmdDataSystem #3106

Merged
merged 1 commit into from
Jan 5, 2024
Merged

rm rcut from DeepmdDataSystem #3106

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 3 additions & 3 deletions deepmd/utils/data_system.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -37,7 +37,7 @@
systems: List[str],
batch_size: int,
test_size: int,
rcut: float,
rcut: Optional[float] = None,
set_prefix: str = "set",
shuffle_test: bool = True,
type_map: Optional[List[str]] = None,
Expand All @@ -59,7 +59,7 @@
test_size
The size of test data
rcut
The cut-off radius
The cut-off radius. Not used.
set_prefix
Prefix for the directories of different sets
shuffle_test
Expand Down Expand Up @@ -91,7 +91,7 @@
descriptors except mixed types.
"""
# init data
self.rcut = rcut
del rcut

Check warning on line 94 in deepmd/utils/data_system.py

View check run for this annotation

Codecov / codecov/patch

deepmd/utils/data_system.py#L94 

Added line #L94 was not covered by tests
self.system_dirs = systems
self.nsystems = len(self.system_dirs)
self.data_systems = []
Expand Down
Loading