Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

only freeze in rank 0 #2937

Merged
merged 1 commit into from
Oct 19, 2023
Merged

only freeze in rank 0 #2937

merged 1 commit into from
Oct 19, 2023

Conversation

njzjz
Copy link
Member

@njzjz njzjz commented Oct 18, 2023

Fix #2272.

@njzjz njzjz requested a review from wanghan-iapcm October 18, 2023 22:34
@njzjz njzjz linked an issue Oct 18, 2023 that may be closed by this pull request
@codecov
Copy link

codecov bot commented Oct 18, 2023

Codecov Report

Attention: 1 lines in your changes are missing coverage. Please review.

Comparison is base (64a5aa8) 72.47% compared to head (b90158b) 75.19%.

Additional details and impacted files
@@            Coverage Diff             @@
##            devel    #2937      +/-   ##
==========================================
+ Coverage   72.47%   75.19%   +2.71%     
==========================================
  Files         245      245              
  Lines       24687    24690       +3     
  Branches     1599     1599              
==========================================
+ Hits        17893    18565     +672     
+ Misses       5862     5189     -673     
- Partials      932      936       +4     
Files Coverage Δ
deepmd/entrypoints/freeze.py 59.30% <75.00%> (+0.13%) ⬆️

... and 35 files with indirect coverage changes

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@wanghan-iapcm wanghan-iapcm merged commit b588928 into deepmodeling:devel Oct 19, 2023
37 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

freezing with mpirun will obtain a wrong model
2 participants