Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix "expression result unused" warnings #2910

Merged
merged 2 commits into from
Oct 11, 2023

Conversation

njzjz
Copy link
Member

@njzjz njzjz commented Oct 10, 2023

See https://en.cppreference.com/w/cpp/error/assert, which shows several ways to avoid unused warnings.

njzjz added 2 commits October 10, 2023 15:38
Signed-off-by: Jinzhe Zeng <[email protected]>
@codecov
Copy link

codecov bot commented Oct 10, 2023

Codecov Report

Attention: 1 lines in your changes are missing coverage. Please review.

Comparison is base (fbaf96b) 75.19% compared to head (6860383) 75.36%.

Additional details and impacted files
@@            Coverage Diff             @@
##            devel    #2910      +/-   ##
==========================================
+ Coverage   75.19%   75.36%   +0.17%     
==========================================
  Files         220      245      +25     
  Lines       20222    24635    +4413     
  Branches      902     1581     +679     
==========================================
+ Hits        15205    18566    +3361     
- Misses       4485     5139     +654     
- Partials      532      930     +398     
Files Coverage Δ
source/api_cc/src/DataModifier.cc 78.66% <ø> (ø)
source/api_cc/src/DeepTensor.cc 78.62% <ø> (ø)
source/lib/include/ComputeDescriptor.h 79.14% <ø> (-0.86%) ⬇️
source/lmp/fix_dplr.cpp 75.18% <ø> (ø)
source/api_cc/src/common.cc 78.36% <0.00%> (ø)

... and 58 files with indirect coverage changes

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@wanghan-iapcm wanghan-iapcm merged commit 66ea4fc into deepmodeling:devel Oct 11, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants