Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Se atten grad grad #2898

Merged
merged 3 commits into from
Oct 7, 2023
Merged

Se atten grad grad #2898

merged 3 commits into from
Oct 7, 2023

Conversation

nahso
Copy link
Collaborator

@nahso nahso commented Oct 4, 2023

fix #2865

image

@codecov
Copy link

codecov bot commented Oct 4, 2023 •
edited
Loading

Codecov Report

Attention: 44 lines in your changes are missing coverage. Please review.

Comparison is base (f256dff) 75.46% compared to head (786fb14) 75.73%.
Report is 3 commits behind head on devel.

Additional details and impacted files 
@@            Coverage Diff             @@
##            devel    #2898      +/-   ##
==========================================
+ Coverage   75.46%   75.73%   +0.27%     
==========================================
  Files         244      245       +1     
  Lines       24522    24918     +396     
  Branches     1580     1617      +37     
==========================================
+ Hits        18505    18872     +367     
+ Misses       5086     5082       -4     
- Partials      931      964      +33
Files Coverage Δ
deepmd/op/_tabulate_grad.py 100.00% <100.00%> (ø)
source/lib/src/tabulate.cc 58.03% <0.00%> (-0.53%) ⬇️
source/op/tabulate_multi_device.cc 54.82% <0.00%> (-5.24%) ⬇️

... and 16 files with indirect coverage changes

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@njzjz njzjz linked an issue Oct 4, 2023 that may be closed by this pull request
[BUG] Significant errors when compressed training se_atten_v2 model #2865
Closed
@njzjz njzjz mentioned this pull request Oct 4, 2023
Open
@njzjz njzjz added the Test CUDA Trigger test CUDA workflow label Oct 4, 2023
@github-actions github-actions bot removed the Test CUDA Trigger test CUDA workflow label Oct 4, 2023
@njzjz
Copy link
Member

njzjz commented Oct 4, 2023

Let's rerun Test CUDA after #2892 is merged.

@wanghan-iapcm wanghan-iapcm added the Test CUDA Trigger test CUDA workflow label Oct 5, 2023
@github-actions github-actions bot removed the Test CUDA Trigger test CUDA workflow label Oct 5, 2023
@wanghan-iapcm wanghan-iapcm requested a review from njzjz October 5, 2023 10:53
njzjz
njzjz approved these changes Oct 5, 2023
View reviewed changes
Copy link
Member

@njzjz njzjz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It looks good to me. It's still unclear to me how the equation is derivated, though...

@wanghan-iapcm wanghan-iapcm merged commit 14c9964 into deepmodeling:devel Oct 7, 2023
38 of 39 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@njzjz njzjz njzjz approved these changes

Assignees
No one assigned
Labels
Core CUDA OP Python ROCM
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[BUG] Significant errors when compressed training se_atten_v2 model
3 participants
@nahso @njzjz @wanghan-iapcm