Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor convert #2854

Merged
merged 2 commits into from
Sep 22, 2023
Merged

refactor convert #2854

merged 2 commits into from
Sep 22, 2023

Conversation

njzjz
Copy link
Member

@njzjz njzjz commented Sep 21, 2023

No description provided.

Signed-off-by: Jinzhe Zeng <[email protected]>
@codecov
Copy link

codecov bot commented Sep 21, 2023

Codecov Report

Patch coverage: 80.00% and project coverage change: +0.13% 🎉

Comparison is base (544875e) 75.24% compared to head (2fe07aa) 75.37%.

Additional details and impacted files
@@            Coverage Diff             @@
##            devel    #2854      +/-   ##
==========================================
+ Coverage   75.24%   75.37%   +0.13%     
==========================================
  Files         242      242              
  Lines       24457    24420      -37     
  Branches     1580     1580              
==========================================
+ Hits        18403    18407       +4     
+ Misses       5123     5082      -41     
  Partials      931      931              
Files Changed Coverage Δ
deepmd/utils/convert.py 95.08% <80.00%> (+24.64%) ⬆️

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Signed-off-by: Jinzhe Zeng <[email protected]>
@njzjz njzjz marked this pull request as ready for review September 21, 2023 21:03
@njzjz njzjz requested a review from wanghan-iapcm September 21, 2023 21:45
Copy link
Collaborator

@Yi-FanLi Yi-FanLi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

A very nice organized way to manage versions. Looks good to me.

@wanghan-iapcm wanghan-iapcm merged commit c2c6476 into deepmodeling:devel Sep 22, 2023
35 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants