-
Notifications
You must be signed in to change notification settings - Fork 526
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
merge cuda and rocm files #2844
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Jinzhe Zeng <[email protected]>
Signed-off-by: Jinzhe Zeng <[email protected]>
Signed-off-by: Jinzhe Zeng <[email protected]>
Signed-off-by: Jinzhe Zeng <[email protected]>
Signed-off-by: Jinzhe Zeng <[email protected]>
Signed-off-by: Jinzhe Zeng <[email protected]>
Signed-off-by: Jinzhe Zeng <[email protected]>
This reverts commit 972919f.
Signed-off-by: Jinzhe Zeng <[email protected]>
Signed-off-by: Jinzhe Zeng <[email protected]>
Signed-off-by: Jinzhe Zeng <[email protected]>
Signed-off-by: Jinzhe Zeng <[email protected]>
njzjz
commented
Sep 19, 2023
7 tasks
njzjz
commented
Sep 19, 2023
Codecov ReportPatch coverage has no change and project coverage change:
Additional details and impacted files@@ Coverage Diff @@
## devel #2844 +/- ##
==========================================
+ Coverage 75.24% 75.66% +0.42%
==========================================
Files 242 243 +1
Lines 24457 24789 +332
Branches 1580 1613 +33
==========================================
+ Hits 18403 18757 +354
+ Misses 5123 5070 -53
- Partials 931 962 +31
☔ View full report in Codecov by Sentry. |
Signed-off-by: Jinzhe Zeng <[email protected]>
Signed-off-by: Jinzhe Zeng <[email protected]>
njzjz
commented
Sep 19, 2023
Signed-off-by: Jinzhe Zeng <[email protected]>
Signed-off-by: Jinzhe Zeng <[email protected]>
Signed-off-by: Jinzhe Zeng <[email protected]>
wanghan-iapcm
approved these changes
Sep 20, 2023
Signed-off-by: Jinzhe Zeng <[email protected]>
denghuilu
approved these changes
Sep 21, 2023
7 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Merge
source/lib/src/cuda
andsource/lib/src/rocm
intosource/lib/src/gpu
.gpuGetLastError
,gpuDeviceSynchronize
,gpuMemcpy
,gpuMemcpyDeviceToHost
,gpuMemcpyHostToDevice
, andgpuMemset
to make them available for both CUDA and ROCm.<<< >>> syntax
for both CUDA and ROCm. Per ROCm/HIP@cf78d85, it has been supported in HIP since 2018.WARP_SIZE
for ROCm. Per [ROCm] define C10_WARP_SIZE to warpSize HIP constant pytorch/pytorch#64302, WARP_SIZE can be 32 or 64, so it should not be hardcoded to 64.GpuShuffleSync
. Per [HIP][device] 4 __shfl_sync functions are missing ROCm/HIP#1491,__shfl_sync
is not supported by HIP.ii
for speedup tabulate cuda kernel by reducing shm using #830 and fix ROCm tabulate_fusion_se_a_grad_fifth_order_polynomial #2357. Although both of them work,ii
has different meanings in these two PRs, but now it should be the same.ii
intabulate_fusion_se_a_fifth_order_polynomial
(rocm) added by Enable model compression for se_atten #2532 is wrong. After merging the codes, it should be corrected.__syncwarp
is not supported by ROCm.