Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

remove _cuda or _rocm suffix #2839

Merged
merged 2 commits into from
Sep 19, 2023
Merged

Conversation

njzjz
Copy link
Member

@njzjz njzjz commented Sep 19, 2023

Remove all _cuda or _rocm suffixes in function names, as proposed in #2838. They can be merged in the following PRs.

(Replace all: gpu_cuda -> gpu; gpu_rocm -> gpu)

Signed-off-by: Jinzhe Zeng <[email protected]>
@wanghan-iapcm wanghan-iapcm enabled auto-merge (squash) September 19, 2023 05:22
@codecov
Copy link

codecov bot commented Sep 19, 2023

Codecov Report

Patch and project coverage have no change.

Comparison is base (0aae8e5) 75.52% compared to head (7b8eff1) 75.52%.

Additional details and impacted files
@@           Coverage Diff           @@
##            devel    #2839   +/-   ##
=======================================
  Coverage   75.52%   75.52%           
=======================================
  Files         242      242           
  Lines       24370    24370           
  Branches     1575     1571    -4     
=======================================
  Hits        18405    18405           
  Misses       5037     5037           
  Partials      928      928           
Files Changed Coverage Δ
source/lib/include/neighbor_list.h 100.00% <ø> (ø)
source/op/gelu_multi_device.cc 25.00% <ø> (ø)
source/op/prod_env_mat_multi_device.cc 70.96% <ø> (ø)
source/op/prod_force_grad_multi_device.cc 67.00% <ø> (ø)
source/op/prod_force_multi_device.cc 64.36% <ø> (ø)
source/op/prod_virial_grad_multi_device.cc 66.93% <ø> (ø)
source/op/prod_virial_multi_device.cc 71.42% <ø> (ø)
source/op/tabulate_multi_device.cc 60.05% <ø> (ø)

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@wanghan-iapcm wanghan-iapcm merged commit 339ce47 into deepmodeling:devel Sep 19, 2023
34 checks passed
@njzjz njzjz linked an issue Sep 26, 2023 that may be closed by this pull request
7 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Feature Request] Merge CUDA and ROCm codes
2 participants