Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

nvnmd: update doc and fix bug in map_flt_nvnmd.cc #2831

Merged
merged 66 commits into from
Sep 27, 2023

Conversation

LiuGroupHNU
Copy link
Collaborator

  1. fix the warning of pytest.marker
  2. fix the bug of map_flt_nvnmd.cc: modify xi >= x1 into xi > x1
  3. update the doc of nvnmd

@codecov
Copy link

codecov bot commented Sep 16, 2023

Codecov Report

Attention: 1 lines in your changes are missing coverage. Please review.

Comparison is base (0d5737f) 75.45% compared to head (0a3eac0) 72.21%.
Report is 27 commits behind head on devel.

Additional details and impacted files
@@            Coverage Diff             @@
##            devel    #2831      +/-   ##
==========================================
- Coverage   75.45%   72.21%   -3.25%     
==========================================
  Files         242      242              
  Lines       24205    24424     +219     
  Branches     1537     1580      +43     
==========================================
- Hits        18265    17638     -627     
- Misses       5023     5863     +840     
- Partials      917      923       +6     
Files Coverage Δ
source/op/map_flt_nvnmd.cc 88.33% <0.00%> (ø)

... and 42 files with indirect coverage changes

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@github-actions github-actions bot removed the Python label Sep 16, 2023
doc/nvnmd/nvnmd.md Outdated Show resolved Hide resolved
Co-authored-by: Jinzhe Zeng <[email protected]>
Signed-off-by: LiuGroupHNU <[email protected]>
@wanghan-iapcm wanghan-iapcm changed the title nvnmd nvnmd: update doc and fix bug in map_flt_nvnmd.cc Sep 27, 2023
@wanghan-iapcm wanghan-iapcm merged commit 498bfa0 into deepmodeling:devel Sep 27, 2023
35 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants