Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

support type embedding changing for frozen .pb #2827

Closed
wants to merge 2 commits into from

Conversation

iProzd
Copy link
Collaborator

@iProzd iProzd commented Sep 15, 2023

No description provided.

@codecov
Copy link

codecov bot commented Sep 15, 2023

Codecov Report

Patch coverage: 9.52% and project coverage change: -0.06% ⚠️

Comparison is base (0d5737f) 75.45% compared to head (08556fe) 75.40%.

Additional details and impacted files
@@            Coverage Diff             @@
##            devel    #2827      +/-   ##
==========================================
- Coverage   75.45%   75.40%   -0.06%     
==========================================
  Files         242      242              
  Lines       24205    24226      +21     
  Branches     1537     1541       +4     
==========================================
+ Hits        18265    18267       +2     
- Misses       5023     5042      +19     
  Partials      917      917              
Files Changed Coverage Δ
deepmd/infer/deep_eval.py 82.48% <9.52%> (-13.21%) ⬇️

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Member

@njzjz njzjz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

To my understanding of this PR, the embedding network has the following requirements:

  • ResNet does not apply;
  • activation function should be an identity function;
  • the number of layers should be 1.

These requirements should be documented.

A better way might be to directly update o_typeebd to a constant instead of updating the NN.

@iProzd iProzd closed this Apr 24, 2024
@iProzd iProzd deleted the tebd_change branch April 24, 2024 09:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants