-
Notifications
You must be signed in to change notification settings - Fork 526
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
add citation for aparam
#2825
Merged
Merged
add citation for aparam
#2825
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This reverts commit e3917fc.
add definition for make_compute_fparam & make_ttm_fparam
now we can use `compute temp` or `fix ttm` to update the fparam each MD step
now we can use `compute temp` or `fix ttm` to update the fparam each MD step
…. function name `make_compute_fparam` is changed to `make_fparam_from_compute`
support fitting electronic density of states (DOS)
add `dos` type
add example and basic doc to hands on the deepdos fitting
for more information, see https://pre-commit.ci
for more information, see https://pre-commit.ci
check the output shape and value of `dos` and `atom_dos`
for more information, see https://pre-commit.ci
if atomic is True, the output of `dos` should be the sum of `atom_dos`
for more information, see https://pre-commit.ci
fix output bug in \fit\dos.py, and add unit test for `DOSFitting`
for more information, see https://pre-commit.ci
for more information, see https://pre-commit.ci
Codecov ReportPatch and project coverage have no change.
Additional details and impacted files@@ Coverage Diff @@
## devel #2825 +/- ##
=======================================
Coverage 75.45% 75.45%
=======================================
Files 242 242
Lines 24205 24205
Branches 1537 1537
=======================================
Hits 18265 18265
Misses 5023 5023
Partials 917 917 ☔ View full report in Codecov by Sentry. |
njzjz
requested changes
Sep 15, 2023
Co-authored-by: Jinzhe Zeng <[email protected]> Signed-off-by: mingzhong15 <[email protected]>
njzjz
approved these changes
Sep 17, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
add reference for
aparam