Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

docs: add theory from v2 paper #2715

Merged
merged 18 commits into from
Nov 2, 2023
Merged

docs: add theory from v2 paper #2715

merged 18 commits into from
Nov 2, 2023

Conversation

njzjz
Copy link
Member

@njzjz njzjz commented Aug 2, 2023 •
edited
Loading

Add theory to documentation.

@github-actions github-actions bot added the Docs label Aug 2, 2023
@codecov
Copy link

codecov bot commented Aug 2, 2023 •
edited
Loading

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (ce75fcb) 75.22% compared to head (bb5ef61) 75.23%.
Report is 7 commits behind head on devel.

Additional details and impacted files 
@@           Coverage Diff           @@
##            devel    #2715   +/-   ##
=======================================
  Coverage   75.22%   75.23%           
=======================================
  Files         245      245           
  Lines       24678    24678           
  Branches     1599     1599           
=======================================
+ Hits        18565    18566    +1     
+ Misses       5177     5176    -1     
  Partials      936      936

see 6 files with indirect coverage changes

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@njzjz njzjz changed the title [WIP] docs: add theory to docs [WIP] docs: add contents of v2 paper (theory, benchmark, etc) to docs Oct 25, 2023
@njzjz njzjz changed the title [WIP] docs: add contents of v2 paper (theory, benchmark, etc) to docs docs: add theory from v2 paper Oct 26, 2023
@njzjz njzjz marked this pull request as ready for review October 26, 2023 04:01
@njzjz
Copy link
Member Author

njzjz commented Oct 26, 2023

CI is fixed in #2950

njzjz
njzjz commented Oct 26, 2023
View reviewed changes
doc/model/train-se-e2-a.md Outdated Show resolved Hide resolved
@njzjz njzjz requested a review from Yi-FanLi October 27, 2023 20:49
Yi-FanLi
Yi-FanLi approved these changes Nov 1, 2023
View reviewed changes
Copy link
Collaborator

@Yi-FanLi Yi-FanLi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I have pointed out some typographical errors. Once you correct those small errors, this PR looks good to me.

doc/model/train-se-e2-r.md Show resolved Hide resolved
doc/model/train-se-e3.md Outdated Show resolved Hide resolved
doc/model/train-se-atten.md Show resolved Hide resolved
doc/train/multi-task-training.md Outdated Show resolved Hide resolved
doc/freeze/compress.md Outdated Show resolved Hide resolved
doc/freeze/compress.md Show resolved Hide resolved
doc/model/train-energy.md Outdated Show resolved Hide resolved
doc/model/train-se-e2-a-tebd.md Outdated Show resolved Hide resolved
doc/model/train-se-e2-a-tebd.md Outdated Show resolved Hide resolved
njzjz added 3 commits November 1, 2023 16:10
@njzjz
fix the render on the GitHub
c69de5e 
Signed-off-by: Jinzhe Zeng <[email protected]>
@njzjz
remove _
fe0efdf 
Signed-off-by: Jinzhe Zeng <[email protected]>
@njzjz
Update doc/model/train-se-e3.md
bb5ef61 
Signed-off-by: Jinzhe Zeng <[email protected]>
@wanghan-iapcm wanghan-iapcm merged commit 1cbe63d into deepmodeling:devel Nov 2, 2023
37 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@wanghan-iapcm wanghan-iapcm wanghan-iapcm approved these changes

@Yi-FanLi Yi-FanLi Yi-FanLi approved these changes

Assignees
No one assigned
Labels
Docs
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@njzjz @Yi-FanLi @wanghan-iapcm