-
Notifications
You must be signed in to change notification settings - Fork 525
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Replace string search with API call in freeze function #3713
Comments
There may be two options: @wanghan-iapcm @iProzd What do you think about it? |
I vote for (1). |
Agree with @wanghan-iapcm. |
Fix #3713. Fix #3733. This is a breaking change. <!-- This is an auto-generated comment: release notes by coderabbit.ai --> ## Summary by CodeRabbit - **New Features** - Introduced a new method `has_message_passing` across various descriptor classes. This method returns a boolean indicating whether the descriptor has message passing capability. <!-- end of auto-generated comment: release notes by coderabbit.ai --> --------- Signed-off-by: Jinzhe Zeng <[email protected]>
Fix deepmodeling#3713. Fix deepmodeling#3733. This is a breaking change. <!-- This is an auto-generated comment: release notes by coderabbit.ai --> ## Summary by CodeRabbit - **New Features** - Introduced a new method `has_message_passing` across various descriptor classes. This method returns a boolean indicating whether the descriptor has message passing capability. <!-- end of auto-generated comment: release notes by coderabbit.ai --> --------- Signed-off-by: Jinzhe Zeng <[email protected]>
In the function of , the model type is currently determined by searching for a string in . This method is not robust and could lead to errors if the string format changes. It is suggested to replace this string search with a dedicated API call that can more reliably determine the model type.
Affected code:
This issue was identified in PR #3657 and discussed in the comments: #3657 (comment)
The text was updated successfully, but these errors were encountered: