Skip to content

Commit

Permalink
do not raise, use pass
Browse files Browse the repository at this point in the history
  • Loading branch information
Han Wang committed Feb 1, 2024
1 parent 2ca139d commit 927007c
Showing 1 changed file with 7 additions and 7 deletions.
14 changes: 7 additions & 7 deletions deepmd/model_format/atomic_model.py
Original file line number Diff line number Diff line change
Expand Up @@ -21,19 +21,19 @@ class BAM(ABC):

@abstractmethod
def get_fitting_output_def(self) -> FittingOutputDef:
raise NotImplementedError
pass

Check warning on line 24 in deepmd/model_format/atomic_model.py

View check run for this annotation

Codecov / codecov/patch

deepmd/model_format/atomic_model.py#L22-L24

Added lines #L22 - L24 were not covered by tests

@abstractmethod
def get_rcut(self) -> float:
raise NotImplementedError
pass

Check warning on line 28 in deepmd/model_format/atomic_model.py

View check run for this annotation

Codecov / codecov/patch

deepmd/model_format/atomic_model.py#L26-L28

Added lines #L26 - L28 were not covered by tests

@abstractmethod
def get_sel(self) -> List[int]:
raise NotImplementedError
pass

Check warning on line 32 in deepmd/model_format/atomic_model.py

View check run for this annotation

Codecov / codecov/patch

deepmd/model_format/atomic_model.py#L30-L32

Added lines #L30 - L32 were not covered by tests

@abstractmethod
def distinguish_types(self) -> bool:
raise NotImplementedError
pass

Check warning on line 36 in deepmd/model_format/atomic_model.py

View check run for this annotation

Codecov / codecov/patch

deepmd/model_format/atomic_model.py#L34-L36

Added lines #L34 - L36 were not covered by tests

@abstractmethod
def forward_atomic(

Check warning on line 39 in deepmd/model_format/atomic_model.py

View check run for this annotation

Codecov / codecov/patch

deepmd/model_format/atomic_model.py#L38-L39

Added lines #L38 - L39 were not covered by tests
Expand All @@ -45,14 +45,14 @@ def forward_atomic(
fparam: Optional[T_Tensor] = None,
aparam: Optional[T_Tensor] = None,
) -> Dict[str, T_Tensor]:
raise NotImplementedError
pass

Check warning on line 48 in deepmd/model_format/atomic_model.py

View check run for this annotation

Codecov / codecov/patch

deepmd/model_format/atomic_model.py#L48

Added line #L48 was not covered by tests

@abstractmethod
def serialize(self) -> dict:
raise NotImplementedError
pass

Check warning on line 52 in deepmd/model_format/atomic_model.py

View check run for this annotation

Codecov / codecov/patch

deepmd/model_format/atomic_model.py#L50-L52

Added lines #L50 - L52 were not covered by tests

@abstractclassmethod
def deserialize(cls):
raise NotImplementedError
pass

Check warning on line 56 in deepmd/model_format/atomic_model.py

View check run for this annotation

Codecov / codecov/patch

deepmd/model_format/atomic_model.py#L54-L56

Added lines #L54 - L56 were not covered by tests

return BAM

Check warning on line 58 in deepmd/model_format/atomic_model.py

View check run for this annotation

Codecov / codecov/patch

deepmd/model_format/atomic_model.py#L58

Added line #L58 was not covered by tests

0 comments on commit 927007c

Please sign in to comment.