Skip to content

Commit

Permalink
fix: lower the atol for DPA2 corner case (#3814)
Browse files Browse the repository at this point in the history
<!-- This is an auto-generated comment: release notes by coderabbit.ai
-->

## Summary by CodeRabbit

- **Bug Fixes**
- Improved precision handling for "float64" in calculations, enhancing
overall accuracy.

<!-- end of auto-generated comment: release notes by coderabbit.ai -->
  • Loading branch information
iProzd authored May 23, 2024
1 parent 55a1cf6 commit 8a359db
Showing 1 changed file with 1 addition and 1 deletion.
2 changes: 1 addition & 1 deletion source/tests/consistent/descriptor/test_dpa2.py
Original file line number Diff line number Diff line change
Expand Up @@ -395,7 +395,7 @@ def atol(self) -> float:
use_econf_tebd,
) = self.param
if precision == "float64":
return 1e-8
return 1e-6 # need to fix in the future, see issue https://github.com/deepmodeling/deepmd-kit/issues/3786
elif precision == "float32":
return 1e-4
else:
Expand Down

0 comments on commit 8a359db

Please sign in to comment.