-
Notifications
You must be signed in to change notification settings - Fork 3
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: fix repeat dict for nb #86
Conversation
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #86 +/- ##
==========================================
- Coverage 78.58% 78.43% -0.15%
==========================================
Files 9 9
Lines 761 765 +4
==========================================
+ Hits 598 600 +2
- Misses 163 165 +2 ☔ View full report in Codecov by Sentry. 🚨 Try these New Features:
|
Caution Review failedThe pull request is closed. 📝 Walkthrough<details>
<summary>📝 Walkthrough</summary>
## Walkthrough
The changes involve modifications to a Jupyter Notebook file, specifically updating the JSON structure within a code cell. The key `"test_repeat"` has been renamed to `"test_repeat_list"` for improved clarity, and a new key `"test_repeat_dict"` has been introduced, which includes a dictionary with two boolean entries. Additionally, the `ArgumentData` class in `dargs/notebook.py` has been updated to refine the logic for initializing `subdata`, allowing for broader handling of data types and improved functionality with an optional `repeat` parameter.
## Changes
| File | Change Summary |
|--------------------|------------------------------------------------------------------------------------------------|
| docs/nb.ipynb | Renamed key `"test_repeat"` to `"test_repeat_list"` and added a new key `"test_repeat_dict"` containing a dictionary with two boolean entries. |
| dargs/notebook.py | Updated `ArgumentData` constructor to include an optional `repeat` parameter. Refined `_init_subdata` method to handle `data` as a dictionary or list based on `repeat`. Adjusted `print_html` method for consistency with new logic. |
## Sequence Diagram(s)
```mermaid
sequenceDiagram
participant User
participant Notebook
participant JSONHandler
User->>Notebook: Request to render JSON
Notebook->>JSONHandler: Prepare JSON with updated structure
JSONHandler-->>Notebook: Return JSON string
Notebook-->>User: Display JSON output
Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media? 🪧 TipsChatThere are 3 ways to chat with CodeRabbit:
Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments. CodeRabbit Commands (Invoked using PR comments)
Other keywords and placeholders
CodeRabbit Configuration File (
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Actionable comments posted: 1
📜 Review details
Configuration used: CodeRabbit UI
Review profile: CHILL
📒 Files selected for processing (1)
docs/nb.ipynb
(1 hunks)
🔇 Additional comments (1)
docs/nb.ipynb (1)
32-35
: LGTM! Clear and descriptive naming.
The rename from "test_repeat" to "test_repeat_list" better describes the array nature of this field.
for more information, see https://pre-commit.ci
Signed-off-by: Jinzhe Zeng <[email protected]>
Summary by CodeRabbit
ArgumentData
class to handle various data structures more effectively, including support for repeatable arguments.print_html
method to maintain correct state during HTML generation.