-
Notifications
You must be signed in to change notification settings - Fork 3
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: add pre-commit hooks #73
Closed
Closed
Changes from all commits
Commits
Show all changes
9 commits
Select commit
Hold shift + click to select a range
0713668
add hook
njzjz adb9c21
strip
njzjz 9abfd09
add test
njzjz a6a7c76
update
njzjz 07b1ab6
feat: add pre-commit hooks
njzjz faecc07
install self
njzjz 1b4090e
remove the test; consider testing it in another way
njzjz c675ac7
set fallback_version
njzjz 44b66fa
Revert "set fallback_version"
njzjz File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,7 @@ | ||
- id: dargs-check | ||
name: dargs-check | ||
description: "Run 'dargs check' to check JSON files." | ||
entry: dargs check | ||
language: python | ||
types_or: [json] | ||
minimum_pre_commit_version: "2.9.2" |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
|
@@ -12,6 +12,7 @@ Welcome to dargs's documentation! | |
|
||
intro | ||
cli | ||
pre-commit | ||
sphinx | ||
dpgui | ||
nb | ||
|
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,16 @@ | ||
# Pre-commit hooks | ||
|
||
To check JSON files (available as of dargs v0.4.8) via [pre-commit](https://github.com/pre-commit/pre-commit), add the following to your `.pre-commit-config.yaml`: | ||
|
||
```yaml | ||
- repo: https://github.com/deepmodeling/dargs | ||
rev: v0.4.8 | ||
hooks: | ||
- id: dargs-check | ||
# Specify the function to return arguments | ||
args: ["-f dargs._test.test_arguments"] | ||
# Pattern of JSON files to check | ||
files: "tests/test_arguments.json" | ||
# Add additional Python dependencies for arguments | ||
additional_dependencies: [] | ||
``` |
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM! Consider adding tests for the new functionality.
The addition of
strip()
ensures that any leading or trailing whitespace in thefunc
string is removed before splitting it to derivemodule_name
andattr_name
. This is a useful change to prevent potential errors due to extra whitespace.However, the new line is not covered by tests.
Do you want me to generate the unit testing code or open a GitHub issue to track this task?
Tools
GitHub Check: codecov/patch