update weighted hamil loss #215
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
QG-phy
reviewed
Oct 15, 2024
| @@ -751,6 +751,11 @@ def loss_options(): | |||
| Argument("onsite_shift", bool, optional=True, default=False, doc="Whether to use onsite shift in loss function. Default: False"), | |||
| ] | |||
|
|
|||
| wt = [ | |||
There was a problem hiding this comment.
这个 wt 怎么用呢？ 用list 指定不同的权重。但是list的顺序和键的顺序，以及原子类型的顺序是无法提前知道的啊？
QG-phy
approved these changes
Dec 23, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This loss is modified based on HamillossBLAS.
The user can optionally provide a weight which can be an int/float scalar or a list of int/float numbers corresponding to the weight of each onsite atom, and bond hopping pairs.