Journal Event fixing bug front/back end #1304

Vilmo18 · 2024-12-09T22:18:04Z

What's new?

Possibility to submit a paper multiple times: The condition allowing multiple applications has been enabled (by commenting out the original condition). If there is a more efficient or cleaner approach, I am open to suggestions.
Addition of new statuses via migrations: Previously, new statuses were added without corresponding database changes. A migration script has now been created to ensure these changes are properly reflected in the database.
Application and status visualization: Users can now visualize their applications and track their current status.
Outcome and response bug fix: Previously, there was one outcome shared across all responses given an event and user. This has been updated so that each response has its own unique outcome. The database structure was modified, migrations were applied, and necessary changes were made to backend files.
Minor bug fixes: Several smaller bugs have been identified and resolved.

avishkar58

Hi Yvan! Thanks so much for this great and very comprehensive PR! Really appreciate all the effort you're putting into this :)
I haven't finished reviewing it yet, but thought I'd submit the few comments I had so far just so I don't block your progress too much. Will try to finish the rest ASAP!

avishkar58 · 2024-12-13T18:09:58Z

api/app/outcome/models.py

@@ -14,6 +14,7 @@ class Outcome(db.Model):
    id = db.Column(db.Integer(), primary_key = True, nullable = False)
    event_id = db.Column(db.Integer(), db.ForeignKey('event.id'), nullable = False)
    user_id = db.Column(db.Integer(), db.ForeignKey('app_user.id'), nullable = False)
+    response_id = db.Column(db.Integer(), db.ForeignKey('response.id'), nullable=False) ## add response_id


Please remove the comments "## add response_id" and "## add relationship"

avishkar58 · 2024-12-13T18:11:45Z

api/app/outcome/repository.py

@@ -28,5 +28,19 @@ def get_latest_for_event(event_id):
    @staticmethod
    def add(outcome):
        db.session.add(outcome)
+


It's probably worth removing the get_*_for_event methods now that outcome is linked to a response? That way we can also ensure all the relevant code paths are updated.

avishkar58 · 2024-12-13T18:12:13Z

api/app/responses/api.py

        for response in responses:
+            outcome = outcome_repository.get_latest_by_user_for_event_response(current_user_id,response.id, event_id)
+            # get_latest_by_user_for_event(current_user_id, event_id)


Please delete commented-out code

avishkar58 · 2024-12-13T18:14:41Z

api/app/responses/api.py

@@ -146,8 +147,8 @@ def post(self):
        user = user_repository.get_by_id(user_id)
        responses = response_repository.get_all_for_user_application(user_id, application_form_id)

-        if not application_form.nominations and len(responses) > 0:
-            return errors.RESPONSE_ALREADY_SUBMITTED
+        # if not application_form.nominations and len(responses) > 0:


I think we still need this check - some events and application forms should still only support a single response and some should support multiple responses and we should validate this is the case. How about changing the name nominations to allows_many_responses to make it more generic? Then default allows_many_responses to True for event-type journal

avishkar58 · 2024-12-13T18:15:02Z

api/migrations/versions/062abca36566_.py

@@ -0,0 +1,22 @@
+"""empty message


Please remove empty migration.

avishkar58 · 2024-12-13T18:25:01Z

api/migrations/versions/67d04fb5a5ed_.py

@@ -0,0 +1,22 @@
+"""empty message


Please remove empty migration

avishkar58 · 2024-12-13T18:25:14Z

api/migrations/versions/ba73c854003e_.py

@@ -0,0 +1,22 @@
+"""empty message


Please remove empty migration

avishkar58 · 2024-12-13T18:25:55Z

webapp/src/components/EventStatus.js

@@ -65,14 +65,20 @@ class EventStatus extends Component {
  applicationStatus = (event) => {
      const applyLink = `${event.key}/apply`
      const submissionLink = `${event.key}/apply/new`
+      const viewLink=`${event.key}/apply/view`
+      console.log(event);


Please remove debug console logs

avishkar58 · 2024-12-13T18:27:16Z

webapp/src/components/EventStatus.js

@@ -91,6 +97,19 @@ class EventStatus extends Component {

      }
      else if (event.status.application_status === "Withdrawn") {
+        if (event.event_type === "JOURNAL"){


It seems like we need some bigger changes here to properly cater for multiple submissions with the event statusus. Currently this doesn't make sense that the event application status is "withdrawn" but the status here says "You have submitted your article"

avishkar58 · 2024-12-13T18:28:29Z

webapp/src/components/form/FormCreator.js

@@ -147,7 +147,8 @@ const FormCreator = ({
        />
      {homeRedirect && <Redirect to={`/${eventKey}`} />}
      {errorResponse ? (
-        <div className='tooltiptext-error response-error'>
+        // tooltiptext-error response-error


Thanks for the fix! Please remove commented code

Vilmo18 · 2024-12-13T22:30:33Z

Hi @avishkar58 ,
Thanks for your comments.
I have already updated the code.
I will submit another PR with more updates soon.

avishkar58 · 2024-12-13T23:09:06Z

webapp/src/pages/ReponseDetails/ResponseDetails.css

@@ -0,0 +1,408 @@
+/* Universal */


Is all of this additional CSS really needed? Also there seems to be a some very generally selectors like html button which should not belong inside a component-specific CSS file.

avishkar58 · 2024-12-13T23:11:44Z

webapp/src/pages/ReponseDetails/components/ReviewModal.js

@@ -0,0 +1,121 @@
+import React, { Component } from "react";


This component doesn't seem to be used? Also seems to be a copy of ResponsePage/components/ReviewModal.js ?

avishkar58 · 2024-12-13T23:15:13Z

webapp/src/pages/applicationForm/components/ApplicationForm.js

+          response={selectedResponse}
+          event={this.props.event}
+        />
+      );
    }


In future, please can you keep formatting changes in a separate PR that only does formatting. When formatting changes are mixed up with other logic changes it makes it very hard for a reviewer to see what has actually changed

avishkar58 · 2024-12-13T23:15:36Z

webapp/src/pages/eventHome/EventHome.js

        <Route
          exact
          path={`${match.path}/apply/new`}
          render={(props) => <Application {...props} event={event} journalSubmissionFlag={true} /> }
        />
+
+        {/*new route */}


Remove uneccessary comment

avishkar58 · 2024-12-13T23:16:18Z

webapp/src/pages/reviewForm/components/ReviewForm.js

@@ -204,9 +204,13 @@ const ReviewForm = (props) => {
            active: currentStage !== 1 ? true : false
          })
          setCreateMode(true);
+          console.log(event);


Remove debug logging

avishkar58 · 2024-12-13T23:16:23Z

webapp/src/services/applicationForm/applicationForm.service.js

@@ -85,6 +85,7 @@ function submit(applicationFormId, isSubmitted, answers) {

    return axios.post(baseUrl + `/api/v1/response`, response, {headers: authHeader()})
      .then(resp=> {
+        console.log()


Vilmo18 added 3 commits December 7, 2024 01:40

journal improvement

af85dad

fixing bug front/back -end - improvement

8df2e2c

fixing bug front/back -end - improvement

69f21ef

avishkar58 reviewed Dec 13, 2024

View reviewed changes

Vilmo18 closed this Dec 15, 2024

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Journal Event fixing bug front/back end #1304

Journal Event fixing bug front/back end #1304

Vilmo18 commented Dec 9, 2024

avishkar58 left a comment

avishkar58 Dec 13, 2024

avishkar58 Dec 13, 2024

avishkar58 Dec 13, 2024

avishkar58 Dec 13, 2024

avishkar58 Dec 13, 2024

avishkar58 Dec 13, 2024

avishkar58 Dec 13, 2024

avishkar58 Dec 13, 2024

avishkar58 Dec 13, 2024

avishkar58 Dec 13, 2024

Vilmo18 commented Dec 13, 2024

avishkar58 Dec 13, 2024

avishkar58 Dec 13, 2024

avishkar58 Dec 13, 2024

avishkar58 Dec 13, 2024

avishkar58 Dec 13, 2024

avishkar58 Dec 13, 2024

Journal Event fixing bug front/back end #1304

Journal Event fixing bug front/back end #1304

Conversation

Vilmo18 commented Dec 9, 2024

avishkar58 left a comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Vilmo18 commented Dec 13, 2024

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment