Add gnark as bls-12-381 backend #551
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Jakub Sztandera <[email protected]>
|
🔒 Could not start CI tests due to missing safe PR label. Please contact a DEDIS maintainer. |
Errcheck was already not checking other impls Signed-off-by: Jakub Sztandera <[email protected]>
|
Stebalien
added a commit
to filecoin-project/go-f3
that referenced
this pull request
Sep 22, 2024
It's probably going to take a while for upstream to merge the changes so we're importing just the changed package (BDN) and the new package (Gnark) into this repo. That way we avoid forking the entire repo but can still import our changes. Any changes to these pacakges should be submitted as PRs to upstream _first_, then backported to this repo. Includes: - dedis/kyber#546 - dedis/kyber#551 - dedis/kyber#553
Stebalien
added a commit
to filecoin-project/go-f3
that referenced
this pull request
Sep 22, 2024
It's probably going to take a while for upstream to merge the changes so we're importing just the changed package (BDN) and the new package (Gnark) into this repo. That way we avoid forking the entire repo but can still import our changes. Any changes to these pacakges should be submitted as PRs to upstream _first_, then backported to this repo. Includes: - dedis/kyber#546 - dedis/kyber#551 - dedis/kyber#553
Stebalien
added a commit
to filecoin-project/go-f3
that referenced
this pull request
Sep 23, 2024
It's probably going to take a while for upstream to merge the changes so we're importing just the changed package (BDN) and the new package (Gnark) into this repo. That way we avoid forking the entire repo but can still import our changes. Any changes to these pacakges should be submitted as PRs to upstream _first_, then backported to this repo. Includes: - dedis/kyber#546 - dedis/kyber#551 - dedis/kyber#553
AnomalRoil
requested changes
Sep 24, 2024
| privhex := suite.Scalar() | ||
| err = privhex.UnmarshalBinary(privkey) | ||
| require.Nil(t, err) | ||
|
|
There was a problem hiding this comment.
Could you add an equality test for pubkey vs pubhex and priveky vs privhex to make sure the points are still the same?
There was a problem hiding this comment.
@Kubuxu Does your 👍🏻 mean you'll be adding the test or should we do it ourselves?
There was a problem hiding this comment.
Fell off from my stack, going to try to get it done soon.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Given that kilic is deprecated (and caused us some issues recently), I'm opening this PR with BLS-12-381 backend using https://github.com/Consensys/gnark-crypto/
The Gnark's BLS-12-381 code was audited in the past (but there have been changes to it since), and it is actively maintained.
Signing performance on G2 is comparable to kilic, while the signing on G1 and public key aggregation performance is better than both circl and kilic.
https://gist.github.com/Stebalien/d6268b5c1abc4aa29857cf7787b205e8