Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add P256 test vectors #543

Merged
merged 4 commits into from
Sep 10, 2024
Merged

Add P256 test vectors #543

merged 4 commits into from
Sep 10, 2024

Conversation

K1li4nL
Copy link
Contributor

@K1li4nL K1li4nL commented Aug 26, 2024

No description provided.

@K1li4nL K1li4nL marked this pull request as ready for review August 26, 2024 14:37
@K1li4nL K1li4nL requested a review from AnomalRoil August 26, 2024 14:37
@K1li4nL K1li4nL added the v4 label Aug 27, 2024
pierluca
pierluca reviewed Sep 1, 2024
View reviewed changes
Copy link
Contributor

@pierluca pierluca left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

What is the license for this data ? 🤔 ideally, it'd be good to include that and verify that it's compatible with MPL 2.0, Kyber's license.

@K1li4nL
Copy link
Contributor Author

K1li4nL commented Sep 2, 2024

What is the license for this data ? 🤔 ideally, it'd be good to include that and verify that it's compatible with MPL 2.0, Kyber's license.

So far I can't find any either, I will try to contact the author

@pierluca
Copy link
Contributor

pierluca commented Sep 4, 2024

Also, is Sonar very wrong here or am I missing something ? 🤔

@sonarqubecloud SonarQubeCloud
Copy link

sonarqubecloud bot commented Sep 9, 2024

Please retry analysis of this Pull-Request directly on SonarCloud

@sonarqubecloud SonarQubeCloud
Copy link

sonarqubecloud bot commented Sep 9, 2024

Quality Gate Failed Quality Gate failed

Failed conditions
81.2% Duplication on New Code (required ≤ 10%)

See analysis details on SonarCloud

AnomalRoil
AnomalRoil approved these changes Sep 10, 2024
View reviewed changes
Copy link
Contributor

@AnomalRoil AnomalRoil left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@K1li4nL K1li4nL merged commit 184128a into master Sep 10, 2024
11 checks passed
@K1li4nL K1li4nL deleted the add-p256-vectors branch September 10, 2024 15:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@pierluca pierluca pierluca left review comments

@AnomalRoil AnomalRoil AnomalRoil approved these changes

Assignees
No one assigned
Labels
safe PR v4
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@K1li4nL @pierluca @AnomalRoil