Bls12381 #505
Bls12381 #505
Conversation
|
|
I know this is a work in progress, but in general adding (a lot) more documentation would be helpful, as right now the code seems mostly undocumented. It would also seem that |
Yep, I'll add some more doc. This was put on hold as I'm waiting the drand fork to be merged before working and merging this PR, to avoid further conflicts |
more comments
* Add ByteOrder() function + constant from int.go * Update circl_bls12381 and edwards25519 scalars * Formatting * Fix typo * Add Order() to the scalar interface * Adapt IBE to make it general * Add doc * Fix dkg bug (#515) * BugFix: use array index instead of node index * Fix endianess bool * Add tests for endianess
|
Please retry analysis of this Pull-Request directly on SonarCloud |
| } | ||
|
|
||
| func (s Suite) Write(w io.Writer, objs ...interface{}) error { | ||
| panic("Suite.Write(): deprecated in drand") | ||
| panic("Suite.Write(): deprecated in kyber") | ||
| } |
There was a problem hiding this comment.
if Suite.Read and Suite.Write are both deprecated, V4 would be a good time to remove them in another PR.
pairing/circl_bls12381/suite_test.go
Outdated
There was a problem hiding this comment.
Why not move this to pairing/cirl/suite_test.go instead of deleting it?
Looks like this file might have been "forgotten" behind, no?
There was a problem hiding this comment.
Oh no, all the methods contained in that file were transferred to general bls12381_test.go, so there was no reason to keep the duplicated tests.
…st of our dependencies
|
1 similar comment
|
This PR introduces a different implementation of bls12381 (kilic) to kyber, which is faster than the actual circl implementation