-
Notifications
You must be signed in to change notification settings - Fork 122
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Tailwindify #1394
base: main
Are you sure you want to change the base?
Tailwindify #1394
Conversation
small?: string; | ||
} | ||
|
||
function FormLabel({ children, htmlFor, small }: FormLabelProps) { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Call this htmlEl
(i.e. element) rather than htmlFor
because that has a very specific other meaning: https://developer.mozilla.org/en-US/docs/Web/API/HTMLLabelElement/htmlFor
function FormLabel({ children, htmlFor, small }: FormLabelProps) { | |
function FormLabel({ children, htmlEl, small }: FormLabelProps) { |
return ( | ||
<Tag | ||
className="m-0 block p-2.5 font-semibold text-[0.9em] text-[color:var(--g1700)]" | ||
{...(htmlFor && { htmlFor })} |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
prefer ?? probably. doesnt matter because typescript but its more precise
<div className={styles.compilerChoiceOr}>or</div> | ||
<div> | ||
<span className={styles.compilerChoiceHeading}> | ||
<div className="flex-0 px-2 py-2 text-center text-[0.8rem] text-[color:var(--g500)] min-[400px]:px-4"> |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Surprised we don't have a tailwind config value for this: text-[color:var(--g500)]
, like text-grey-500
or something. If not we should raise an issue about doing that
Don't merge until #1392