Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Tailwindify #1394

Open
wants to merge 53 commits into
base: main
Choose a base branch
from
Open

Tailwindify #1394

wants to merge 53 commits into from

Conversation

ethteck
Copy link
Member

@ethteck ethteck commented Dec 8, 2024

Don't merge until #1392

@ethteck ethteck changed the title Tailwind Tailwindify Dec 8, 2024
@ethteck ethteck marked this pull request as ready for review December 15, 2024 15:55
@ethteck ethteck requested a review from bates64 as a code owner December 15, 2024 15:55
small?: string;
}

function FormLabel({ children, htmlFor, small }: FormLabelProps) {
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Call this htmlEl (i.e. element) rather than htmlFor because that has a very specific other meaning: https://developer.mozilla.org/en-US/docs/Web/API/HTMLLabelElement/htmlFor

Suggested change
function FormLabel({ children, htmlFor, small }: FormLabelProps) {
function FormLabel({ children, htmlEl, small }: FormLabelProps) {

return (
<Tag
className="m-0 block p-2.5 font-semibold text-[0.9em] text-[color:var(--g1700)]"
{...(htmlFor && { htmlFor })}
Copy link
Member

@bates64 bates64 Dec 20, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

prefer ?? probably. doesnt matter because typescript but its more precise

<div className={styles.compilerChoiceOr}>or</div>
<div>
<span className={styles.compilerChoiceHeading}>
<div className="flex-0 px-2 py-2 text-center text-[0.8rem] text-[color:var(--g500)] min-[400px]:px-4">
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Surprised we don't have a tailwind config value for this: text-[color:var(--g500)] , like text-grey-500 or something. If not we should raise an issue about doing that

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants