Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

introduce connect mobile to mobile flow #159

Merged
merged 3 commits into from
Oct 24, 2023
Merged

introduce connect mobile to mobile flow #159

merged 3 commits into from
Oct 24, 2023

Conversation

shamilovtim
Copy link
Contributor

Reason for PR

For the flow where the DWA is on the same mobile device as the wallet, we call this the "mobile to mobile" flow.

Implementation

  • Added a deeplink config to the path (/connect)
  • Use the implementation from the QR code scanner and parse the params when deeplinking
RPReplay_Final1698124018.MP4

@shamilovtim shamilovtim requested a review from amika-sq October 24, 2023 05:26
@shamilovtim shamilovtim linked an issue Oct 24, 2023 that may be closed by this pull request
Add mobile to mobile flow (deeplinking with params) to web5 connect #132
Closed
@shamilovtim shamilovtim self-assigned this Oct 24, 2023
Base automatically changed from tshamilov/high-fidelity-qr to main October 24, 2023 15:16
@shamilovtim shamilovtim merged commit 5d7bd01 into main Oct 24, 2023
@shamilovtim shamilovtim deleted the tshamilov/mobile-to-mobile-connect branch October 24, 2023 17:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@amika-sq amika-sq amika-sq approved these changes

Assignees

@shamilovtim shamilovtim

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Add mobile to mobile flow (deeplinking with params) to web5 connect
2 participants
@shamilovtim @amika-sq