Add starters for bindings/web5_c and bound/golang
#359
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
KendallWeihe
requested review from
nitro-neal,
shamilovtim,
diehuxx,
frankhinek and
leordev
as code owners
nitro-neal
reviewed
Sep 23, 2024
| use web5::crypto::jwk::Jwk; | ||
|
|
||
| #[no_mangle] | ||
| pub extern "C" fn poc_key_manager_from_foreign(manager: *const CKeyManager) { |
There was a problem hiding this comment.
this is a test basically?
There was a problem hiding this comment.
yup! it proves the injection of a foreign implementation of a key manager
nitro-neal
reviewed
Sep 23, 2024
nitro-neal
approved these changes
Sep 23, 2024
|
lots of errors in linter, maybe need to disable for bindings/web5_c or edit |
KendallWeihe
force-pushed
the
kendall/bind-go-starter
branch
from
0531071 to
76ade28
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Marking this as a draft for now, opening for visibility