Add key manager unit tests, add Web5Error::Mutex #304
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
KendallWeihe
requested review from
nitro-neal,
kirahsapong,
shamilovtim,
diehuxx,
decentralgabe,
frankhinek,
leordev and
ALRubinger
as code owners
diehuxx
reviewed
Aug 22, 2024
bound/kt/src/test/kotlin/web5/sdk/crypto/keys/InMemoryKeyManagerTest.kt
Outdated
Show resolved
Hide resolved
diehuxx
reviewed
Aug 22, 2024
diehuxx
reviewed
Aug 22, 2024
| public_jwk.d = None; | ||
|
|
||
| let result = key_manager.import_private_jwk(public_jwk); | ||
| assert!(result.is_err()); |
There was a problem hiding this comment.
nit: instead of asserting is_err() and is_ok(), how do you feel about expect_err("private_jwk must be a private key") and expect("whatever the helpful error message is")? slightly tighter than asserting Ok/Err than unwrapping in the following line
|
Need to rebase and use the latest from #303 prior to merging this (remove all instances of LazyLock!) |
KendallWeihe
force-pushed
the
kendall/key-managers
branch
from
cc4b3f5 to
9568f26
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.