Web5 test vectors #284
Merged
Web5 test vectors #284
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
nitro-neal
requested review from
KendallWeihe,
kirahsapong,
shamilovtim,
diehuxx,
decentralgabe,
frankhinek,
leordev and
ALRubinger
as code owners
|
|
||
| // As a replay attack protection protocol, if the same DID is doing a GET request within 5 minutes of each other, instead of a 404 it will start returning a 429. | ||
| // to get around this for our test we just create a new DID that is not published to get a fresh 404 for this error code | ||
| // if(vector_output.did_resolution_metadata.error == "notFound") { |
There was a problem hiding this comment.
think we can remove this line, yeah?
KendallWeihe
approved these changes
Aug 15, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.