Add resolution for did:jwk #245
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
KendallWeihe
requested review from
nitro-neal,
kirahsapong,
shamilovtim,
diehuxx,
decentralgabe and
frankhinek
as code owners
nitro-neal
reviewed
Jun 24, 2024
| @@ -1,7 +1,6 @@ | |||
| namespace web5 { | |||
| JwkData ed25519_generator_generate(); | |||
|
|
|||
| [Throws=RustCoreError] | |||
There was a problem hiding this comment.
did this mean to get removed?
There was a problem hiding this comment.
yeah, because we're moving to all resolve() functions returning a ResolutionResult wherein the error case is represented via the ResolutionMetadataError
KendallWeihe
commented
Jun 24, 2024
| use crate::apid::crypto::key_managers::in_memory_key_manager::InMemoryKeyManager; | ||
|
|
||
| #[test] | ||
| fn can_instantiate_did_jwk() { |
There was a problem hiding this comment.
we'll come back through and use test vectors once we have them
nitro-neal
reviewed
Jun 24, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.