fix: disable jsonschema resolution to support web5-rs in WASM builds #230
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Without disabling the resolve-http feature, the jsonschema crate fails to build on WASM environments due to use of `reqwest::blocking`, which is not built in WASM environments. Stranger6667/jsonschema#222 has additional context. The use of jsonschema, currently at least, does not use resolution and is used against a schema defined in code for Verifiable Credentials
enmand
requested review from
KendallWeihe,
nitro-neal,
kirahsapong,
shamilovtim,
diehuxx,
decentralgabe and
frankhinek
as code owners
KendallWeihe
approved these changes
Jun 12, 2024
There was a problem hiding this comment.
WASM isn't within scope of the existing Rust Core Working Group, but so long as this doesn't impact the set of deliverables then it's great if we can enable WASM compatibility! ✅
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Without disabling the resolve-http feature, the jsonschema crate fails to build on WASM environments due to use of
reqwest::blocking, which is not built in WASM environments. Stranger6667/jsonschema#222 has additional context.The use of jsonschema, currently at least, does not use resolution and is used against a schema defined in code for Verifiable Credentials.