One crate #225
Merged
One crate #225
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 9 commits
June 3, 2024 11:10
diehuxx
requested review from
KendallWeihe,
nitro-neal,
kirahsapong,
shamilovtim,
decentralgabe and
frankhinek
as code owners
* main: update timestamps (#222)
nitro-neal
reviewed
Jun 3, 2024
| @@ -106,7 +106,7 @@ impl Default for LocalKeyManager { | |||
|
|
|||
| #[cfg(test)] | |||
| mod tests { | |||
| use crate::key::Key; | |||
| use crate::keys::key::Key; | |||
There was a problem hiding this comment.
later on we can think of a different names if people see this when they import from kotlin or something 😆
nitro-neal
reviewed
Jun 3, 2024
| sha2 = "0.10.8" | ||
| simple-dns = "0.7.0" | ||
| ssi-core = "0.1.0" | ||
| ssi-dids = "0.1.1" |
There was a problem hiding this comment.
yep, we're using ssi-dids and ssi-core for our did:web and did:jwk.
nitro-neal
approved these changes
Jun 3, 2024
added 2 commits
June 3, 2024 12:53
* main: Convert dht doc to dns packet (#224)
KendallWeihe
reviewed
Jun 5, 2024
| uniffi = { version = "0.27.1", features = ["cli"] } | ||
|
|
||
| [build-dependencies] | ||
| uniffi = { version = "0.27.1", features = ["build"] } | ||
|
|
||
| [lib] | ||
| crate-type = ["cdylib"] | ||
| name = "web5" |
There was a problem hiding this comment.
FYI this is relevant to the binding scripts #227
KendallWeihe
reviewed
Jun 5, 2024
| @@ -237,7 +237,7 @@ impl JsonSchemaBuilder { | |||
| mod tests { | |||
| use std::collections::HashSet; | |||
|
|
|||
| use test_helpers::TestVectorFile; | |||
| use crate::test_helpers::TestVectorFile; | |||
There was a problem hiding this comment.
There was a problem hiding this comment.
Or, thoughts on simply
core/src/Cargo.toml- etc.
Meaning, just lean hard into only a single crate?
Any of the above three are fine because the compiler will handle performance matters, so it's purely cosmetic, just ideating
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Consolidate all crates into one. In a future PR, we will probably want to more neatly export specific items and un-nest some items from their deeply nested modules, rather than just
pub moding everything. But this PR is just to move us to one crate with minimal changes.