Convert dht doc to dns packet #224
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
diehuxx
requested review from
KendallWeihe,
nitro-neal,
kirahsapong,
shamilovtim,
decentralgabe and
frankhinek
as code owners
diehuxx
force-pushed
the
convert-doc-to-dns
branch
from
22cd45a to
3405197
Compare
nitro-neal
reviewed
Jun 3, 2024
| // 6. Create document | ||
| Ok(Document { | ||
| id: did_uri, | ||
| context: None, |
There was a problem hiding this comment.
Is context: None on purpose?
There was a problem hiding this comment.
Yep, it is. did:dht does not use context
nitro-neal
reviewed
Jun 3, 2024
nitro-neal
approved these changes
Jun 3, 2024
diehuxx
force-pushed
the
convert-doc-to-dns
branch
from
0ba32fa to
f4431de
Compare
Co-authored-by: nitro-neal <[email protected]>
diehuxx
pushed a commit
that referenced
this pull request
Jun 3, 2024
* main: Convert dht doc to dns packet (#224)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The last step in converting between did:dht documents and DNS packets. This includes:
Possibly in follow up PR: More test coverage for
Document::to_packetandDocument::from_packetfor unhappy paths.