Add bep44 encoded for did:dht #209
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
diehuxx
requested review from
KendallWeihe,
nitro-neal,
kirahsapong,
shamilovtim,
decentralgabe and
frankhinek
as code owners
crates/dids/src/method/dht/bep44.rs
Outdated
| use keys::key::{KeyError, PublicKey}; | ||
|
|
||
| const MIN_MESSAGE_LEN: usize = 72; | ||
| const MAX_MESSAGE_LEN: usize = 1072; |
There was a problem hiding this comment.
Might want to split this into something like "max V length" since the sign and seq are separate and we need to enforce that v is no longer than 1000b
There was a problem hiding this comment.
I added a const MAX_V_LEN and some documentation to keep it more clear. We need to do the check on MIN_MESSAGE_LEN at the beginner of decode() regardless so we don't try to access an index out of bounds.
crates/dids/src/method/dht/bep44.rs
Outdated
| let seq: u64 = SystemTime::now() | ||
| .duration_since(UNIX_EPOCH)? | ||
| .as_micros() | ||
| .try_into() |
There was a problem hiding this comment.
I'm not sure what this does but the spec has the seq in seconds https://did-dht.com/#create
There was a problem hiding this comment.
Ah that's a mistake because copied it blindly from web5-dart. Here's a PR to update it in dart decentralized-identity/web5-dart#87
KendallWeihe
approved these changes
May 14, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR does not yet make use of the bep44 mod. In a follow up PR that implements
DidDht::create, this encoder will actually be used.See also the dart implementation: https://github.com/TBD54566975/web5-dart/blob/main/packages/web5/lib/src/dids/did_dht/bep44.dart