Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add JWS tests #193

Merged
merged 3 commits into from
May 10, 2024
Merged

Add JWS tests #193

merged 3 commits into from
May 10, 2024

Conversation

kirahsapong
Copy link
Contributor

@kirahsapong kirahsapong commented May 9, 2024

Closes #166

  • Adds tests for JWS signing, decoding, verification
  • Rename unsupported algorithm error


let result = CompactJws::verify(&compact_jws).await;

assert!(matches!(result, Err(JwsError::MalformedHeader(_))));
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

fyi I just opened #191 earlier, it's kinda relevant here, not proposing a change just making you aware

Copy link
Contributor

@nitro-neal nitro-neal left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks great to me!

@kirahsapong kirahsapong marked this pull request as ready for review May 10, 2024 16:42
@kirahsapong kirahsapong merged commit e0ce61c into main May 10, 2024
6 checks passed
@kirahsapong kirahsapong deleted the feat/add-jws-tests branch May 10, 2024 16:48
@KendallWeihe
Copy link
Contributor

really awesome work here 💯

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add tests for JWS
3 participants