Automatically setup rustup in just recipes #136
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
KendallWeihe
requested review from
nitro-neal,
kirahsapong,
shamilovtim,
diehuxx,
decentralgabe and
frankhinek
as code owners
nitro-neal
approved these changes
Apr 30, 2024
jiyoonie9
reviewed
Apr 30, 2024
| cargo build --release | ||
|
|
||
| test: | ||
| test: setup |
There was a problem hiding this comment.
adding setup for in these lines runs just setup first?
There was a problem hiding this comment.
that's right
we're using rustup which is an aggregation of many underlying rust dependencies, but it has to be setup (rustup default stable downloads and installs all the latest stable versions). by adding setup as a dependency, that step is automatically handled.
cc @nitro-neal same question
jiyoonie9
approved these changes
Apr 30, 2024
decentralgabe
approved these changes
Apr 30, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #123