Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Corrected UnionMessageReply type for downstream consumption #821

Merged
merged 2 commits into from
Oct 8, 2024

Conversation

thehenrytsai
Copy link
Contributor

@thehenrytsai thehenrytsai commented Oct 7, 2024

Corrected UnionMessageReply type due to changes to #817 for downstream consumption such as the dwn-server.

@codecov-commenter
Copy link

codecov-commenter commented Oct 7, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 98.72%. Comparing base (475270d) to head (baa9652).

Additional details and impacted files
@@            Coverage Diff             @@
##             main     #821      +/-   ##
==========================================
- Coverage   98.72%   98.72%   -0.01%     
==========================================
  Files          74       74              
  Lines       11509    11499      -10     
  Branches     1661     1661              
==========================================
- Hits        11362    11352      -10     
  Misses        141      141              
  Partials        6        6              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Member

@LiranCohen LiranCohen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🙇 🙏 🐐

@thehenrytsai thehenrytsai merged commit e983cd8 into main Oct 8, 2024
4 checks passed
@thehenrytsai thehenrytsai deleted the henrytsai/union-message-reply branch October 8, 2024 01:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants