Updated RecordsRead to return RecordsDelete and initial RecordsWrite when record is deleted #814
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…when record is deleted
thehenrytsai
requested review from
mistermoe,
csuwildcat and
LiranCohen
as code owners
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #814 +/- ##
=======================================
Coverage 98.71% 98.72%
=======================================
Files 74 74
Lines 11469 11508 +39
Branches 1652 1661 +9
=======================================
+ Hits 11322 11361 +39
Misses 141 141
Partials 6 6 ☔ View full report in Codecov by Sentry. |
thehenrytsai
commented
Oct 3, 2024
csuwildcat
previously approved these changes
Oct 3, 2024
LiranCohen
previously approved these changes
Oct 4, 2024
thehenrytsai
dismissed stale reviews from LiranCohen and csuwildcat
via
6276e5e
Co-authored-by: Liran Cohen <[email protected]>
This was referenced Oct 29, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Prior to this change, a 404 status is returned without any data when a RecordsRead is performed against a deleted record.
But 404 status alone prevents a the RecordsDelete from being imported into the caller's DWN for the purpose updating the record's state.
This PR updated RecordsRead to return RecordsDelete and initial RecordsWrite when record is deleted.