generated from TBD54566975/tbd-project-template
-
Notifications
You must be signed in to change notification settings - Fork 105
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
RecordsQuery & RecordsSubscribe supports an array for author
and recipient
#777
Merged
LiranCohen
merged 8 commits into
main
from
lirancohen/filter-by-recipient-or-author-array
Aug 20, 2024
Merged
RecordsQuery & RecordsSubscribe supports an array for author
and recipient
#777
LiranCohen
merged 8 commits into
main
from
lirancohen/filter-by-recipient-or-author-array
Aug 20, 2024
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #777 +/- ##
=======================================
Coverage 98.62% 98.63%
=======================================
Files 73 73
Lines 11293 11335 +42
Branches 1616 1628 +12
=======================================
+ Hits 11138 11180 +42
Misses 149 149
Partials 6 6 ☔ View full report in Codecov by Sentry. |
LiranCohen
force-pushed
the
lirancohen/filter-by-recipient-or-author-array
branch
2 times, most recently
from
August 15, 2024 20:27
02e1266
to
35b5119
Compare
LiranCohen
requested review from
mistermoe,
csuwildcat and
thehenrytsai
as code owners
August 16, 2024 14:43
csuwildcat
previously approved these changes
Aug 16, 2024
LiranCohen
force-pushed
the
lirancohen/filter-by-recipient-or-author-array
branch
from
August 19, 2024 18:35
15bf9d0
to
c06f76a
Compare
csuwildcat
approved these changes
Aug 20, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Introduce filtering by multiple authors or recipients. The filters are backward compatible, so that
author
andrecipient
filters now accept astring
orArray<string>
.NOTE: If an empty array is passed into the filter, it is treated as an undefined filter.