Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

RecordsQuery & RecordsSubscribe supports an array for author and recipient #777

Merged
merged 8 commits into from
Aug 20, 2024

Conversation

LiranCohen
Copy link
Member

@LiranCohen LiranCohen commented Jul 1, 2024

Introduce filtering by multiple authors or recipients. The filters are backward compatible, so that author and recipient filters now accept a string or Array<string>.

NOTE: If an empty array is passed into the filter, it is treated as an undefined filter.

@codecov-commenter
Copy link

codecov-commenter commented Jul 1, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 98.63%. Comparing base (8d574ed) to head (c06f76a).

Additional details and impacted files
@@           Coverage Diff           @@
##             main     #777   +/-   ##
=======================================
  Coverage   98.62%   98.63%           
=======================================
  Files          73       73           
  Lines       11293    11335   +42     
  Branches     1616     1628   +12     
=======================================
+ Hits        11138    11180   +42     
  Misses        149      149           
  Partials        6        6           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@LiranCohen LiranCohen force-pushed the lirancohen/filter-by-recipient-or-author-array branch 2 times, most recently from 02e1266 to 35b5119 Compare August 15, 2024 20:27
@LiranCohen LiranCohen marked this pull request as ready for review August 16, 2024 14:43
@LiranCohen LiranCohen marked this pull request as draft August 16, 2024 14:48
@LiranCohen LiranCohen marked this pull request as ready for review August 16, 2024 21:12
csuwildcat
csuwildcat previously approved these changes Aug 16, 2024
@LiranCohen LiranCohen force-pushed the lirancohen/filter-by-recipient-or-author-array branch from 15bf9d0 to c06f76a Compare August 19, 2024 18:35
@LiranCohen LiranCohen requested a review from csuwildcat August 19, 2024 18:41
@LiranCohen LiranCohen merged commit 9f25759 into main Aug 20, 2024
4 checks passed
@LiranCohen LiranCohen deleted the lirancohen/filter-by-recipient-or-author-array branch August 20, 2024 15:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants