Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

remove use of dataStream for ProtocolsConfigure in tests #528

Merged
merged 1 commit into from
Oct 2, 2023
Merged

remove use of dataStream for ProtocolsConfigure in tests #528

merged 1 commit into from
Oct 2, 2023

Conversation

flothjl
Copy link
Contributor

@flothjl flothjl commented Oct 2, 2023

fixes #451

@codesandbox
Copy link

codesandbox bot commented Oct 2, 2023

Review or Edit in CodeSandbox

Open the branch in Web Editor • VS Code • Insiders

Open Preview

@flothjl flothjl marked this pull request as ready for review October 2, 2023 02:45
@EbonyLouis EbonyLouis added the hacktoberfest-accepted Accepted PRs for the hacking month of October label Oct 2, 2023
diehuxx
diehuxx approved these changes Oct 2, 2023
View reviewed changes
Copy link

@diehuxx diehuxx left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thanks!

@diehuxx diehuxx merged commit 9c4e1a1 into decentralized-identity:main Oct 2, 2023
@flothjl flothjl deleted the flothjl/remove-datastream-tests branch October 4, 2023 15:48
diehuxx pushed a commit that referenced this pull request Oct 4, 2023
Merge branch 'main' into diehuxx/role-write
35fe439 
* main:
  #526 - Fix typos in the README.md file (#527)
  remove unnecessary datastream from being passed for ProtocolsConfigure (#528)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@diehuxx diehuxx diehuxx approved these changes

@mistermoe mistermoe Awaiting requested review from mistermoe mistermoe is a code owner

@csuwildcat csuwildcat Awaiting requested review from csuwildcat csuwildcat is a code owner

@thehenrytsai thehenrytsai Awaiting requested review from thehenrytsai

Assignees
No one assigned
Labels
hacktoberfest-accepted Accepted PRs for the hacking month of October
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Remove reference and use of dataStream everywhere in tests
3 participants
@flothjl @diehuxx @EbonyLouis