-
Notifications
You must be signed in to change notification settings - Fork 105
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Protocol action "of" validation #520
Protocol action "of" validation #520
Conversation
Review or Edit in CodeSandboxOpen the branch in Web Editor • VS Code • Insiders |
@flothjl Just a heads-up: To be eligible for the official Hacktoberfest prizes, PRs need to be merged on or after October 1st. Would you like to wait until then or merge it now?
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks @flothjl -- @thehenrytsai and I made a small change and merged main. Like @EbonyLouis said, if you want to be part of the Hacktoberfest thing, we'll wait to merge this until Sunday Oct 1st. Or feel free to merge it sooner, it's up to you.
@diehuxx @EbonyLouis I'm really okay either way here. It doesn't look like I have rights to merge. If waiting until 10/1 helps TBD's Hacktoberfest 🍁 standings I can just reopen the PR on Sunday, otherwise I'm fine if y'all just merge now :). |
* main: decentralized-identity#439 - Return `authorization` in queries and reads (decentralized-identity#523) decentralized-identity#439 - Turned `authorization` property from a JWS into a container object (decentralized-identity#518) npm audit fix get-func-name (decentralized-identity#521)
Fixes #507
Moving protocol action rule "of" validation to javascript to improve error messaging.
Debated trying to leverage an ajv plugin to help improve error messaging during schema validation, but a couple of things stood out:
Ajv
instance to return all errors in a validation instead of stopping after the first error.$actions
was added recently with Authorize RecordsRead with globalRole #512