add golangci-lint to CI and address outstanding issues (#105)

.github/workflows/ci.yml

@@ -59,4 +59,10 @@ jobs:
         run: mage build
 
       - name: Test
-        run: mage citest
+        run: mage citest
+
+      - name: golangci-lint
+        uses: golangci/golangci-lint-action@v3
+        with:
+          version: latest
+          working-directory: impl

impl/pkg/server/server_test.go

@@ -1,8 +1,6 @@
 package server
 
 import (
-	"bytes"
-	"io"
 	"net/http"
 	"net/http/httptest"
 	"os"
@@ -12,7 +10,6 @@ import (
 
 	"github.com/gin-gonic/gin"
 	"github.com/stretchr/testify/assert"
-	"github.com/stretchr/testify/require"
 
 	"github.com/TBD54566975/did-dht-method/config"
 )
@@ -53,13 +50,6 @@ func is2xxResponse(statusCode int) bool {
 	return statusCode/100 == 2
 }
 
-func newJSONRequestValue(t *testing.T, data any) io.Reader {
-	dataBytes, err := json.Marshal(data)
-	require.NoError(t, err)
-	require.NotEmpty(t, dataBytes)
-	return bytes.NewReader(dataBytes)
-}
-
 // construct a context value as expected by our handler
 func newRequestContext(w http.ResponseWriter, req *http.Request) *gin.Context {
 	c, _ := gin.CreateTestContext(w)

impl/pkg/service/pkarr.go

@@ -128,12 +128,17 @@ func (s *PkarrService) PublishPkarr(ctx context.Context, id string, request Publ
 
 	// return here and put it in the DHT asynchronously
 	// TODO(gabe): consider a background process to monitor failures
-	go s.dht.Put(ctx, bep44.Put{
-		V:   request.V,
-		K:   &request.K,
-		Sig: request.Sig,
-		Seq: request.Seq,
-	})
+	go func() {
+		_, err := s.dht.Put(ctx, bep44.Put{
+			V:   request.V,
+			K:   &request.K,
+			Sig: request.Sig,
+			Seq: request.Seq,
+		})
+		if err != nil {
+			logrus.WithError(err).Error("error from dht.Put")
+		}
+	}()
 
 	return nil
 }