Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: add name query param to wearable collections from builder #6260

Merged
merged 4 commits into from
Dec 5, 2024

Conversation

lorux0
Copy link
Collaborator

@lorux0 lorux0 commented Dec 3, 2024

What does this PR change?

Adds the possibility to filter preview wearables (from builder) using the search bar in the backpack.
Additionally the pagination of wearable collections fetched from the builder has been reworked, so we can properly fetch massive collections.

How to test the changes?

  1. Launch the explorer with: link
  2. Open the backpack
  3. Use the search bar
  4. Check that the items from the preview collection are filtered by name
  5. Check other collections either published or not using the &WITH_COLLECTIONS parameter
  6. Check that all the items are available to preview
  7. Check custom wearables using the parameter &WITH_ITEMS either published or not.
  8. Check that all the items are available to preview

Our Code Review Standards

https://github.com/decentraland/unity-renderer/blob/master/docs/code-review-standards.md

Copilot summary

copilot:summary

@lorux0 lorux0 requested a review from dalkia December 4, 2024 16:06
@Ludmilafantaniella Ludmilafantaniella self-requested a review December 4, 2024 19:29
@lorux0 lorux0 merged commit ae68fec into dev Dec 5, 2024
11 checks passed
@lorux0 lorux0 deleted the feat/preview-collections-text-filter branch December 5, 2024 14:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants