Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: copy paste contextual menu #5540

Draft
wants to merge 24 commits into
base: dev
Choose a base branch
from
Draft

feat: copy paste contextual menu #5540

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
24 commits
Select commit Hold shift + click to select a range
f4b4674
implemented chat message copy to clipboard and namespace refactoring
lorux0 Jul 24, 2023
ff7f548
included notification when copying a chat message's text
lorux0 Jul 24, 2023
4f47854
added test coverage in ChatHUDController
lorux0 Jul 24, 2023
60345a7
implemented user name copy from user context menu
lorux0 Jul 25, 2023
063b7b7
copy user names and channel names from context menues
lorux0 Jul 25, 2023
f8d145f
implemented copy channel name from channel chat window
lorux0 Jul 25, 2023
66888bb
implemented copy location from minimap
lorux0 Jul 26, 2023
9f95e01
integrated toast when copying the location from minimap
lorux0 Jul 26, 2023
d3808b5
integrated toast & copy icon to user contextual menu
lorux0 Jul 26, 2023
e2b9e09
integrated toast for copying the channel name from the context menu
lorux0 Jul 26, 2023
b007b16
integrated toast & button to chat entries
lorux0 Jul 26, 2023
2c04913
missing PrivateChatEntrySent.prefab
lorux0 Jul 26, 2023
8a78484
added @ at the beginning of the name to be copied
lorux0 Jul 26, 2023
5a16e6c
integrated hover & click sound
lorux0 Jul 26, 2023
6b49da6
implemented copy of profile description
lorux0 Jul 28, 2023
a7db236
added toast when copying profile description
lorux0 Jul 28, 2023
1d33ac9
fixed chat entry toast being clipped by mask
lorux0 Jul 28, 2023
86c56c3
fixed prefab loading at UserContextMenuShould
lorux0 Jul 28, 2023
0309bc8
toast text modifications & minimap layout polishment
lorux0 Jul 28, 2023
50d30a7
improved passport on hover showing/hiding copy button
lorux0 Jul 28, 2023
6ee63e9
fixed name font size in user context menu
lorux0 Jul 28, 2023
13ffcc0
fixed toast alignment on minimap
lorux0 Jul 28, 2023
8854a62
changed colors of like and copy button in minimap
lorux0 Jul 28, 2023
0297653
implemented copy/paste contextual menu in chat input
lorux0 Jul 31, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 3 additions & 1 deletion unity-renderer/Assets/Desktop/Scripts/MainScripts/DCL/Controllers/HUD/HUDDesktop.asmdef
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -26,7 +26,9 @@
"GUID:301149363e31a4bdaa1943465a825c8e",
"GUID:4d7712e4b2446440a8af21fd3ce8690e",
"GUID:81f3218b29e049144b175dad2ebbac1b",
"GUID:006c0e0a70294dbba8a4cbcfb77e1f7d"
"GUID:006c0e0a70294dbba8a4cbcfb77e1f7d",
"GUID:2ce94b4811f2a4b9b8dfd650158f7796",
"GUID:e5b8a8ed154ad624f99bcb73d3284a90"
],
"includePlatforms": [
"Editor",
Expand Down
3 changes: 2 additions & 1 deletion unity-renderer/Assets/Desktop/Scripts/MainScripts/DCL/Controllers/HUD/HUDDesktopFactory.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -54,7 +54,8 @@ public override async UniTask<IHUD> CreateHUD(HUDElementID hudElementId, Cancell
new WebInterfaceHomeLocationController(),
DCL.Environment.i,
DCL.Environment.i.serviceLocator.Get<IPlacesAPIService>(),
new PlacesAnalytics());
new PlacesAnalytics(),
Clipboard.Create());
break;

default:
Expand Down
5 changes: 3 additions & 2 deletions ...ts/Desktop/Scripts/MainScripts/DCL/Controllers/HUD/Minimap/MinimapHUDControllerDesktop.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -12,8 +12,9 @@ public MinimapHUDControllerDesktop(
IHomeLocationController locationController,
Environment.Model environment,
IPlacesAPIService placesAPIService,
IPlacesAnalytics placesAnalytics
IPlacesAnalytics placesAnalytics,
IClipboard clipboard
)
: base(minimapMetadataController, locationController, environment, placesAPIService, placesAnalytics) { }
: base(minimapMetadataController, locationController, environment, placesAPIService, placesAnalytics, clipboard) { }
}
}
3 changes: 2 additions & 1 deletion ...r/Assets/Desktop/Scripts/MainScripts/DCL/Controllers/HUD/Minimap/MinimapHUDDesktop.asmdef
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -7,7 +7,8 @@
"GUID:0e967802b778d404eac1ca5ea340e290",
"GUID:2f3b53e8380cc4aae947b17780173adb",
"GUID:fbcc413e192ef9048811d47ab0aca0c0",
"GUID:006c0e0a70294dbba8a4cbcfb77e1f7d"
"GUID:006c0e0a70294dbba8a4cbcfb77e1f7d",
"GUID:e5b8a8ed154ad624f99bcb73d3284a90"
],
"includePlatforms": [
"Editor",
Expand Down
6 changes: 6 additions & 0 deletions unity-renderer/Assets/Scripts/MainScripts/DCL/Controllers/ChatController/ChatUtils.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -15,5 +15,11 @@ public static string AddNoParse(string message)
filteredMessage = filteredMessage.Insert(filteredMessage.Length, "</noparse>");
return filteredMessage;
}

public static string RemoveNoParse(string message)
{
return message.Replace("<noparse>", "")
.Replace("</noparse>", "");
}
}
}
3 changes: 2 additions & 1 deletion unity-renderer/Assets/Scripts/MainScripts/DCL/Controllers/HUD/ChatWidgetHUD/ChatEntry.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,7 +1,7 @@
using System;
using UnityEngine;

namespace DCL.Chat.HUD
namespace DCL.Social.Chat
{
public abstract class ChatEntry : MonoBehaviour
{
Expand All @@ -14,6 +14,7 @@ public abstract class ChatEntry : MonoBehaviour
public abstract event Action<ChatEntry, ParcelCoordinates> OnTriggerHoverGoto;
public abstract event Action OnCancelHover;
public abstract event Action OnCancelGotoHover;
public abstract event Action<ChatEntry> OnCopyClicked;

public abstract ChatEntryModel Model { get; }
public abstract void Populate(ChatEntryModel model);
Expand Down
6 changes: 5 additions & 1 deletion unity-renderer/Assets/Scripts/MainScripts/DCL/Controllers/HUD/ChatWidgetHUD/ChatHUD.asmdef
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -32,7 +32,11 @@
"GUID:5cd5fb11f1b1d104586dec3f36722223",
"GUID:55b66aa56b81d2d4cafb4a5f02bc90ca",
"GUID:2995626b54c60644988f134a69a77450",
"GUID:e31367fcee1378a4e83de1f9cd2c161d"
"GUID:e31367fcee1378a4e83de1f9cd2c161d",
"GUID:e5b8a8ed154ad624f99bcb73d3284a90",
"GUID:e99faafecbf8dd74d8130597511b9b27",
"GUID:7fe146b43e76fe745aeaf2020feb54b7",
"GUID:2ce94b4811f2a4b9b8dfd650158f7796"
],
"includePlatforms": [],
"excludePlatforms": [],
Expand Down
Loading