fix: initial parcelObservable notification not being called (#611)

decentraland · Oct 19, 2022 · 29238aa · 29238aa
1 parent 5e7504c
commit 29238aa
Show file tree

Hide file tree

Showing 2 changed files with 6 additions and 2 deletions.
diff --git a/packages/shared/world/SceneWorker.ts b/packages/shared/world/SceneWorker.ts
@@ -343,6 +343,7 @@ export class SceneWorker {
   private subscribeToSceneChangeEvents() {
     this.sceneChangeObserver = sceneObservable.add((report) => {
       const userId = getCurrentUserId(store.getState())
+
       if (userId) {
         const sceneId = this.loadableScene.id
         if (report.newScene?.id === sceneId) {

diff --git a/packages/shared/world/positionThings.ts b/packages/shared/world/positionThings.ts
@@ -53,12 +53,15 @@ positionObservable.add((event) => {
   lastPlayerPositionReport = event
 })
 
-// Listen to position changes, and notify if the parcel changed
+let calledInitialParcelNotification = false
 let lastPlayerParcel: Vector2
+// Listen to position changes, and notify if the parcel changed
 positionObservable.add(({ position, immediate }) => {
   const parcel = Vector2.Zero()
   worldToGrid(position, parcel)
-  if (!lastPlayerParcel || parcel.x !== lastPlayerParcel.x || parcel.y !== lastPlayerParcel.y) {
+
+  if (!calledInitialParcelNotification || parcel.x !== lastPlayerParcel.x || parcel.y !== lastPlayerParcel.y) {
+    calledInitialParcelNotification = true
     parcelObservable.notifyObservers({ previousParcel: lastPlayerParcel, newParcel: parcel, immediate })
     setLastPlayerParcel(parcel)
   }