Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

expose players components (ADR-245) and set deprecation apis #743

Closed

Conversation

leanmendoza
Copy link
Contributor

@leanmendoza leanmendoza commented Sep 20, 2023

This is a PoC that could work with decentraland/unity-renderer#5724

The goal of this PR could be to remove the sendBatch from SDK6 in the SDK7.

What?

  • Expose player components defined https://adr.decentraland.org/adr/ADR-245
  • Tag AvatarEmoteCommand as Grow Only Set component
  • Remove old APIs exposed and tagged as deprecated the same method as the .proto has.
  • TODO: Infer observables from data components
  • Add send and receive in the communication controller

@cloudflare-workers-and-pages
Copy link

cloudflare-workers-and-pages bot commented Sep 20, 2023

Deploying with  Cloudflare Pages  Cloudflare Pages

Latest commit: d6d00dc
Status: ✅  Deploy successful!
Preview URL: https://c7bb70e9.js-sdk-toolchain.pages.dev
Branch Preview URL: https://feat-implement-avatar-compon.js-sdk-toolchain.pages.dev

View logs

@github-actions
Copy link
Contributor

github-actions bot commented Sep 20, 2023

Test this pull request

  • The @dcl/sdk package can be tested in scenes by running

    npm install "https://sdk-team-cdn.decentraland.org/@dcl/js-sdk-toolchain/branch/feat/implement-avatar-components-and-sdk7-observables/dcl-sdk-7.3.16-6268686741.commit-1dc82da.tgz"
  • To test with npx init

    export SDK_COMMANDS="https://sdk-team-cdn.decentraland.org/@dcl/js-sdk-toolchain/branch/feat/implement-avatar-components-and-sdk7-observables/dcl-sdk-commands-7.3.16-6268686741.commit-1dc82da.tgz"
    npx $SDK_COMMANDS init
  • The @dcl/inspector package can be tested by visiting this url

    • Or by installing it via NPM
    npm install "https://sdk-team-cdn.decentraland.org/@dcl/js-sdk-toolchain/branch/feat/implement-avatar-components-and-sdk7-observables/@dcl/inspector/dcl-inspector-7.3.16-6268686741.commit-1dc82da.tgz"
  • The /changerealm command to test test in-world

    /changerealm https://sdk-team-cdn.decentraland.org/ipfs/feat/implement-avatar-components-and-sdk7-observables-e2e
    
  • You can preview this build entering:
    https://playground.decentraland.org/?sdk-branch=feat/implement-avatar-components-and-sdk7-observables

@codecov
Copy link

codecov bot commented Sep 20, 2023

Codecov Report

Patch coverage: 10.93% and project coverage change: -1.94% ⚠️

Comparison is base (694446b) 72.28% compared to head (d6d00dc) 70.35%.

Additional details and impacted files
@@            Coverage Diff             @@
##             main     #743      +/-   ##
==========================================
- Coverage   72.28%   70.35%   -1.94%     
==========================================
  Files         364      137     -227     
  Lines       12127     4395    -7732     
  Branches     1616      748     -868     
==========================================
- Hits         8766     3092    -5674     
+ Misses       3175     1197    -1978     
+ Partials      186      106      -80     
Files Changed Coverage Δ
packages/@dcl/sdk/src/observables.ts 0.00% <0.00%> (-100.00%) ⬇️
...engine/grow-only-value-set-component-definition.ts 30.85% <20.00%> (-69.15%) ⬇️
...src/engine/lww-element-set-component-definition.ts 84.00% <71.42%> (-16.00%) ⬇️

... and 237 files with indirect coverage changes

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@leanmendoza leanmendoza changed the title wip expose players components (ADR-245) and set deprecation apis Sep 21, 2023
@gonpombo8 gonpombo8 closed this Mar 4, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants