feat: lod generator #60
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
aleortega
reviewed
Feb 27, 2024
asset-bundle-converter/Assets/AssetBundleConverter/Editor/ExportFBXAssetBundles.cs
Outdated
Show resolved
Hide resolved
…ndle-converter into feat/lod-generator
Kinerius
approved these changes
Mar 12, 2024
| string[] commandLineArgs = Environment.GetCommandLineArgs(); | ||
|
|
||
| string customOutputDirectory = ""; | ||
| string lodsURL = "https://lods-bucket-ed4300a.s3.amazonaws.com/-17,-21/LOD/Sources/1707776785658/bafkreidnwpjkv3yoxsz6iiqh3fahuec7lfsqtmkyz3yf6dgps454ngldnu_0.fbx;" + |
There was a problem hiding this comment.
do we want these URLs to be public?
There was a problem hiding this comment.
Ideally, no. We tried integrating the amazon api to make them private; but due to time constraints, we dropped it. We are looking forward to make the downloader using the amazon api in the hardening week.
Then, they will be private
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.