Feat: Scene Shader #55
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Collaborator
mikhail-dcl
commented
Nov 1, 2023
•
mikhail-dcl
commented
- A new shader from Geoff "DCL/Scene" is used for AB conversion for Standalone (Explorer Alpha only)
- Unity upgraded to 2022.3.2f1 as this shader is based on the newer URP
- Docker images are upgraded accordingly
- Materials generation divided into 2 paths:
- For WebGL the old one is used with no changes
- For Standalone the new "Scene" shader with Bounds Checking is used
- Shaders variants collection is included in the same shader bundle to ensure all possible (according to the GLTF conversion) combinations are compiled. It's needed to use the bundled material/shader directly without the necessity to re-assign it on the client side
* simplification of materials generation * various clean-up
* Resolved the bug with Materials' spontaneous destruction
Kinerius
reviewed
Nov 21, 2023
Comment on lines
-440
to
-443
| var previousMat = env.assetDatabase.LoadAssetAtPath<Material>(materialPath); | ||
|
|
||
| if (previousMat != null) | ||
| env.assetDatabase.DeleteAsset(materialPath); |
There was a problem hiding this comment.
This was QOL debug code, to avoid creating multiple materials when re-running the conversion on the same scene over and over without re-downloading everything from scratch
There was a problem hiding this comment.
I will revert it 👌
There was a problem hiding this comment.
I think I recall why I removed it: it's not needed as we override it later
env.assetDatabase.CreateAsset(newMaterial, materialPath);
Kinerius
approved these changes
Nov 21, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.