Skip to content

Commit

Permalink
Change the shader to "DCL/Scene" for Standalone
Browse files Browse the repository at this point in the history
  • Loading branch information
mikhail-dcl committed Oct 23, 2023
1 parent 574f675 commit 447679d
Show file tree
Hide file tree
Showing 14 changed files with 143 additions and 46 deletions.
6 changes: 3 additions & 3 deletions .github/workflows/docker.yml
Original file line number Diff line number Diff line change
Expand Up @@ -8,13 +8,13 @@ jobs:
strategy:
matrix:
include:
- unity_docker_image: unityci/editor:2021.3.22f1-webgl-1
- unity_docker_image: unityci/editor:2022.3.2f1-webgl-1
service_name: asset-bundle-converter
platform_target: webgl
- unity_docker_image: unityci/editor:2021.3.22f1-windows-mono-1
- unity_docker_image: unityci/editor:2022.3.2f1-windows-mono-1
service_name: asset-bundle-converter-windows
platform_target: windows
- unity_docker_image: unityci/editor:2021.3.22f1-mac-mono-1
- unity_docker_image: unityci/editor:2022.3.2f1-mac-mono-1
service_name: asset-bundle-converter-mac
platform_target: mac

Expand Down
6 changes: 3 additions & 3 deletions .github/workflows/manual-build-conversion.yml
Original file line number Diff line number Diff line change
Expand Up @@ -23,13 +23,13 @@ jobs:
strategy:
matrix:
include:
- unity_docker_image: unityci/editor:2021.3.22f1-webgl-1
- unity_docker_image: unityci/editor:2022.3.2f1-webgl-1
service_name: asset-bundle-converter
platform_target: webgl
- unity_docker_image: unityci/editor:2021.3.22f1-windows-mono-1
- unity_docker_image: unityci/editor:2022.3.2f1-windows-mono-1
service_name: asset-bundle-converter-windows
platform_target: windows
- unity_docker_image: unityci/editor:2021.3.22f1-mac-mono-1
- unity_docker_image: unityci/editor:2022.3.2f1-mac-mono-1
service_name: asset-bundle-converter-mac
platform_target: mac

Expand Down
6 changes: 3 additions & 3 deletions Dockerfile
Original file line number Diff line number Diff line change
Expand Up @@ -46,9 +46,9 @@ ENV NODE_PATH $NVM_DIR/versions/node/$NODE_VERSION/lib/node_modules
ENV PATH $NVM_DIR/versions/node/$NODE_VERSION/bin:$PATH

# Change this value ONLY if we have done breaking changes for every material, doing so is VERY costly
ENV AB_VERSION v11
ENV AB_VERSION_WINDOWS v14
ENV AB_VERSION_MAC v15
ENV AB_VERSION v12
ENV AB_VERSION_WINDOWS v15
ENV AB_VERSION_MAC v16

# NODE_ENV is used to configure some runtime options, like JSON logger
ENV NODE_ENV production
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -40,6 +40,8 @@ public class AssetBundleSceneConversionWindow : EditorWindow
private string entityId = "QmYy2TMDEfag99yZV4ZdpjievYUfdQgBVfFHKCDAge3zQi";
private string wearablesCollectionId = "urn:decentraland:off-chain:base-avatars";
private string debugEntity = "bafkreib66ufmbowp4ee2u3kdu6t52kouie7kd7tfrlv3l5kejz6yjcaq5i";

// The empty scenes url should be like "https://cdn.decentraland.org/@dcl/explorer/1.0.152291-20231017100112.commit-07d38e3/loader/empty-scenes/contents/"
private string mappingName = "../mappings.json";
private string batchBaseUrl = "";
private string batchSceneId = "";
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -4,6 +4,15 @@ namespace AssetBundleConverter.Wrappers.Implementations.Default
{
public class AssetBundleConverterMaterialGenerator : DecentralandMaterialGenerator
{
public AssetBundleConverterMaterialGenerator() : base("DCL/Universal Render Pipeline/Lit") { }
public AssetBundleConverterMaterialGenerator() : base(GetShaderName()) { }

private static string GetShaderName()
{
#if UNITY_WEBGL
return "DCL/Universal Render Pipeline/Lit";
#else
return "DCL/Scene";
#endif
}
}
}
}
Original file line number Diff line number Diff line change
Expand Up @@ -12,8 +12,8 @@ MonoBehaviour:
m_Script: {fileID: 11500000, guid: bf2edee5c58d82540a51f03df9d42094, type: 3}
m_Name: UniversalRenderPipelineAsset
m_EditorClassIdentifier:
k_AssetVersion: 9
k_AssetPreviousVersion: 9
k_AssetVersion: 11
k_AssetPreviousVersion: 11
m_RendererType: 1
m_RendererData: {fileID: 0}
m_RendererDataList:
Expand All @@ -23,13 +23,16 @@ MonoBehaviour:
m_RequireOpaqueTexture: 1
m_OpaqueDownsampling: 0
m_SupportsTerrainHoles: 0
m_StoreActionsOptimization: 0
m_SupportsHDR: 1
m_HDRColorBufferPrecision: 0
m_MSAA: 8
m_RenderScale: 1
m_UpscalingFilter: 0
m_FsrOverrideSharpness: 0
m_FsrSharpness: 0.92
m_EnableLODCrossFade: 1
m_LODCrossFadeDitheringType: 1
m_ShEvalMode: 0
m_MainLightRenderingMode: 1
m_MainLightShadowsSupported: 1
m_MainLightShadowmapResolution: 2048
Expand All @@ -50,16 +53,21 @@ MonoBehaviour:
m_CascadeBorder: 0.1
m_ShadowDepthBias: 1
m_ShadowNormalBias: 1
m_AnyShadowsSupported: 1
m_SoftShadowsSupported: 0
m_ConservativeEnclosingSphere: 0
m_NumIterationsEnclosingSphere: 64
m_SoftShadowQuality: 2
m_AdditionalLightsCookieResolution: 2048
m_AdditionalLightsCookieFormat: 3
m_UseSRPBatcher: 1
m_SupportsDynamicBatching: 0
m_MixedLightingSupported: 1
m_SupportsLightCookies: 1
m_SupportsLightLayers: 0
m_DebugLevel: 0
m_StoreActionsOptimization: 0
m_EnableRenderGraph: 0
m_UseAdaptivePerformance: 1
m_ColorGradingMode: 0
m_ColorGradingLutSize: 32
Expand All @@ -69,6 +77,33 @@ MonoBehaviour:
m_LocalShadowsAtlasResolution: 256
m_MaxPixelLights: 0
m_ShadowAtlasResolution: 256
m_ShaderVariantLogLevel: 0
m_VolumeFrameworkUpdateMode: 0
m_Textures:
blueNoise64LTex: {fileID: 2800000, guid: e3d24661c1e055f45a7560c033dbb837, type: 3}
bayerMatrixTex: {fileID: 2800000, guid: f9ee4ed84c1d10c49aabb9b210b0fc44, type: 3}
m_PrefilteringModeMainLightShadows: 3
m_PrefilteringModeAdditionalLight: 3
m_PrefilteringModeAdditionalLightShadows: 2
m_PrefilterXRKeywords: 1
m_PrefilteringModeForwardPlus: 0
m_PrefilteringModeDeferredRendering: 0
m_PrefilteringModeScreenSpaceOcclusion: 0
m_PrefilterDebugKeywords: 1
m_PrefilterWriteRenderingLayers: 1
m_PrefilterHDROutput: 1
m_PrefilterSSAODepthNormals: 1
m_PrefilterSSAOSourceDepthLow: 1
m_PrefilterSSAOSourceDepthMedium: 1
m_PrefilterSSAOSourceDepthHigh: 1
m_PrefilterSSAOInterleaved: 1
m_PrefilterSSAOBlueNoise: 1
m_PrefilterSSAOSampleCountLow: 1
m_PrefilterSSAOSampleCountMedium: 1
m_PrefilterSSAOSampleCountHigh: 1
m_PrefilterDBufferMRT1: 1
m_PrefilterDBufferMRT2: 1
m_PrefilterDBufferMRT3: 1
m_PrefilterScreenCoord: 1
m_PrefilterNativeRenderPass: 1
m_ShaderVariantLogLevel: 0
m_ShadowCascades: 0
Original file line number Diff line number Diff line change
Expand Up @@ -14,21 +14,23 @@ MonoBehaviour:
m_EditorClassIdentifier:
debugShaders:
debugReplacementPS: {fileID: 4800000, guid: cf852408f2e174538bcd9b7fda1c5ae7, type: 3}
hdrDebugViewPS: {fileID: 4800000, guid: 573620ae32aec764abd4d728906d2587, type: 3}
m_RendererFeatures: []
m_RendererFeatureMap:
m_UseNativeRenderPass: 0
postProcessData: {fileID: 11400000, guid: 41439944d30ece34e96484bdb6645b55, type: 2}
xrSystemData: {fileID: 11400000, guid: 60e1133243b97e347b653163a8c01b64, type: 2}
shaders:
blitPS: {fileID: 4800000, guid: c17132b1f77d20942aa75f8429c0f8bc, type: 3}
copyDepthPS: {fileID: 4800000, guid: d6dae50ee9e1bfa4db75f19f99355220, type: 3}
screenSpaceShadowPS: {fileID: 4800000, guid: 0f854b35a0cf61a429bd5dcfea30eddd, type: 3}
samplingPS: {fileID: 4800000, guid: 04c410c9937594faa893a11dceb85f7e, type: 3}
stencilDeferredPS: {fileID: 4800000, guid: e9155b26e1bc55942a41e518703fe304, type: 3}
fallbackErrorPS: {fileID: 4800000, guid: e6e9a19c3678ded42a3bc431ebef7dbd, type: 3}
fallbackLoadingPS: {fileID: 4800000, guid: 7f888aff2ac86494babad1c2c5daeee2, type: 3}
materialErrorPS: {fileID: 4800000, guid: 5fd9a8feb75a4b5894c241777f519d4e, type: 3}
coreBlitPS: {fileID: 4800000, guid: 93446b5c5339d4f00b85c159e1159b7c, type: 3}
coreBlitColorAndDepthPS: {fileID: 4800000, guid: d104b2fc1ca6445babb8e90b0758136b, type: 3}
blitHDROverlay: {fileID: 4800000, guid: a89bee29cffa951418fc1e2da94d1959, type: 3}
cameraMotionVector: {fileID: 4800000, guid: c56b7e0d4c7cb484e959caeeedae9bbf, type: 3}
objectMotionVector: {fileID: 4800000, guid: 7b3ede40266cd49a395def176e1bc486, type: 3}
m_AssetVersion: 2
Expand All @@ -50,6 +52,4 @@ MonoBehaviour:
m_DepthPrimingMode: 0
m_CopyDepthMode: 0
m_AccurateGbufferNormals: 0
m_ClusteredRendering: 0
m_TileSize: 32
m_IntermediateTextureMode: 1
Original file line number Diff line number Diff line change
Expand Up @@ -12,7 +12,17 @@ MonoBehaviour:
m_Script: {fileID: 11500000, guid: 2ec995e51a6e251468d2a3fd8a686257, type: 3}
m_Name: UniversalRenderPipelineGlobalSettings
m_EditorClassIdentifier:
k_AssetVersion: 2
k_AssetVersion: 3
m_RenderingLayerNames:
- Light Layer default
- Light Layer 1
- Light Layer 2
- Light Layer 3
- Light Layer 4
- Light Layer 5
- Light Layer 6
- Light Layer 7
m_ValidRenderingLayers: 255
lightLayerName0: Light Layer default
lightLayerName1: Light Layer 1
lightLayerName2: Light Layer 2
Expand All @@ -24,4 +34,8 @@ MonoBehaviour:
m_StripDebugVariants: 1
m_StripUnusedPostProcessingVariants: 0
m_StripUnusedVariants: 1
m_StripUnusedLODCrossFadeVariants: 1
m_StripScreenCoordOverrideVariants: 1
supportRuntimeDebugDisplay: 0
m_ShaderVariantLogLevel: 0
m_ExportShaderVariants: 1
Submodule unity-shared-dependencies updated 57 files
+0 −1 Runtime/Shaders/SRPBatchingHelper.cs
+8 −0 Runtime/Shaders/SceneRendering.meta
+8 −0 Runtime/Shaders/SceneRendering/LightCookie.meta
+117 −0 Runtime/Shaders/SceneRendering/LightCookie/Scene_LightCookie.hlsl
+7 −0 Runtime/Shaders/SceneRendering/LightCookie/Scene_LightCookie.hlsl.meta
+126 −0 Runtime/Shaders/SceneRendering/LightCookie/Scene_LightCookieInput.hlsl
+7 −0 Runtime/Shaders/SceneRendering/LightCookie/Scene_LightCookieInput.hlsl.meta
+13 −0 Runtime/Shaders/SceneRendering/LightCookie/Scene_LightCookieTypes.hlsl
+7 −0 Runtime/Shaders/SceneRendering/LightCookie/Scene_LightCookieTypes.hlsl.meta
+308 −0 Runtime/Shaders/SceneRendering/Scene.shader
+9 −0 Runtime/Shaders/SceneRendering/Scene.shader.meta
+68 −0 Runtime/Shaders/SceneRendering/Scene_AmbientOcclusion.hlsl
+7 −0 Runtime/Shaders/SceneRendering/Scene_AmbientOcclusion.hlsl.meta
+256 −0 Runtime/Shaders/SceneRendering/Scene_BRDF.hlsl
+7 −0 Runtime/Shaders/SceneRendering/Scene_BRDF.hlsl.meta
+665 −0 Runtime/Shaders/SceneRendering/Scene_BSDF.hlsl
+7 −0 Runtime/Shaders/SceneRendering/Scene_BSDF.hlsl.meta
+107 −0 Runtime/Shaders/SceneRendering/Scene_Clustering.hlsl
+7 −0 Runtime/Shaders/SceneRendering/Scene_Clustering.hlsl.meta
+168 −0 Runtime/Shaders/SceneRendering/Scene_Core.hlsl
+7 −0 Runtime/Shaders/SceneRendering/Scene_Core.hlsl.meta
+131 −0 Runtime/Shaders/SceneRendering/Scene_DepthNormalsPass.hlsl
+7 −0 Runtime/Shaders/SceneRendering/Scene_DepthNormalsPass.hlsl.meta
+47 −0 Runtime/Shaders/SceneRendering/Scene_DepthOnlyPass.hlsl
+7 −0 Runtime/Shaders/SceneRendering/Scene_DepthOnlyPass.hlsl.meta
+288 −0 Runtime/Shaders/SceneRendering/Scene_EntityLighting.hlsl
+7 −0 Runtime/Shaders/SceneRendering/Scene_EntityLighting.hlsl.meta
+253 −0 Runtime/Shaders/SceneRendering/Scene_ForwardPass.hlsl
+7 −0 Runtime/Shaders/SceneRendering/Scene_ForwardPass.hlsl.meta
+460 −0 Runtime/Shaders/SceneRendering/Scene_GlobalIllumination.hlsl
+7 −0 Runtime/Shaders/SceneRendering/Scene_GlobalIllumination.hlsl.meta
+713 −0 Runtime/Shaders/SceneRendering/Scene_ImageBasedLighting.hlsl
+7 −0 Runtime/Shaders/SceneRendering/Scene_ImageBasedLighting.hlsl.meta
+88 −0 Runtime/Shaders/SceneRendering/Scene_Input.hlsl
+7 −0 Runtime/Shaders/SceneRendering/Scene_Input.hlsl.meta
+216 −0 Runtime/Shaders/SceneRendering/Scene_InputData.hlsl
+7 −0 Runtime/Shaders/SceneRendering/Scene_InputData.hlsl.meta
+482 −0 Runtime/Shaders/SceneRendering/Scene_Lighting.hlsl
+7 −0 Runtime/Shaders/SceneRendering/Scene_Lighting.hlsl.meta
+137 −0 Runtime/Shaders/SceneRendering/Scene_Mat.mat
+8 −0 Runtime/Shaders/SceneRendering/Scene_Mat.mat.meta
+322 −0 Runtime/Shaders/SceneRendering/Scene_RealtimeLights.hlsl
+7 −0 Runtime/Shaders/SceneRendering/Scene_RealtimeLights.hlsl.meta
+17 −0 Runtime/Shaders/SceneRendering/Scene_ShaderVariablesFunctions.deprecated.hlsl
+7 −0 Runtime/Shaders/SceneRendering/Scene_ShaderVariablesFunctions.deprecated.hlsl.meta
+535 −0 Runtime/Shaders/SceneRendering/Scene_ShaderVariablesFunctions.hlsl
+7 −0 Runtime/Shaders/SceneRendering/Scene_ShaderVariablesFunctions.hlsl.meta
+73 −0 Runtime/Shaders/SceneRendering/Scene_ShadowCasterPass.hlsl
+7 −0 Runtime/Shaders/SceneRendering/Scene_ShadowCasterPass.hlsl.meta
+11 −0 Runtime/Shaders/SceneRendering/Scene_Shadows.deprecated.hlsl
+7 −0 Runtime/Shaders/SceneRendering/Scene_Shadows.deprecated.hlsl.meta
+513 −0 Runtime/Shaders/SceneRendering/Scene_Shadows.hlsl
+7 −0 Runtime/Shaders/SceneRendering/Scene_Shadows.hlsl.meta
+16 −0 Runtime/Shaders/SceneRendering/Scene_SurfaceData.hlsl
+7 −0 Runtime/Shaders/SceneRendering/Scene_SurfaceData.hlsl.meta
+62 −0 Runtime/Shaders/SceneRendering/Scene_SurfaceInput.hlsl
+7 −0 Runtime/Shaders/SceneRendering/Scene_SurfaceInput.hlsl.meta
9 changes: 5 additions & 4 deletions asset-bundle-converter/Packages/manifest.json
Original file line number Diff line number Diff line change
Expand Up @@ -3,13 +3,14 @@
"com.atteneder.draco": "4.0.2",
"com.atteneder.ktx": "2.2.3",
"com.cysharp.unitask": "https://github.com/Cysharp/UniTask.git?path=src/UniTask/Assets/Plugins/UniTask",
"com.unity.collab-proxy": "2.0.1",
"com.unity.ai.navigation": "1.1.3",
"com.unity.collab-proxy": "2.0.4",
"com.unity.ide.rider": "3.0.21",
"com.unity.ide.visualstudio": "2.0.17",
"com.unity.ide.visualstudio": "2.0.18",
"com.unity.ide.vscode": "1.2.5",
"com.unity.meshopt.decompress": "0.1.0-preview.5",
"com.unity.render-pipelines.universal": "12.1.10",
"com.unity.scriptablebuildpipeline": "1.20.2",
"com.unity.render-pipelines.universal": "14.0.8",
"com.unity.scriptablebuildpipeline": "1.21.5",
"com.unity.test-framework": "2.0.1-pre.18",
"io.sentry.unity": "https://github.com/getsentry/unity.git",
"net.tnrd.nsubstitute": "https://github.com/decentraland/Unity3D-NSubstitute.git",
Expand Down
48 changes: 35 additions & 13 deletions asset-bundle-converter/Packages/packages-lock.json
Original file line number Diff line number Diff line change
Expand Up @@ -25,8 +25,17 @@
"dependencies": {},
"hash": "305695ad5d194dda0d6b00777c2459202a1ef4ea"
},
"com.unity.ai.navigation": {
"version": "1.1.3",
"depth": 0,
"source": "registry",
"dependencies": {
"com.unity.modules.ai": "1.0.0"
},
"url": "https://packages.unity.com"
},
"com.unity.burst": {
"version": "1.8.2",
"version": "1.8.4",
"depth": 1,
"source": "registry",
"dependencies": {
Expand All @@ -35,7 +44,7 @@
"url": "https://packages.unity.com"
},
"com.unity.collab-proxy": {
"version": "2.0.1",
"version": "2.0.4",
"depth": 0,
"source": "registry",
"dependencies": {},
Expand All @@ -58,7 +67,7 @@
"url": "https://packages.unity.com"
},
"com.unity.ide.visualstudio": {
"version": "2.0.17",
"version": "2.0.18",
"depth": 0,
"source": "registry",
"dependencies": {
Expand Down Expand Up @@ -91,47 +100,48 @@
"url": "https://packages.unity.com"
},
"com.unity.render-pipelines.core": {
"version": "12.1.10",
"version": "14.0.8",
"depth": 1,
"source": "builtin",
"dependencies": {
"com.unity.ugui": "1.0.0",
"com.unity.modules.physics": "1.0.0",
"com.unity.modules.terrain": "1.0.0",
"com.unity.modules.jsonserialize": "1.0.0"
}
},
"com.unity.render-pipelines.universal": {
"version": "12.1.10",
"version": "14.0.8",
"depth": 0,
"source": "builtin",
"dependencies": {
"com.unity.mathematics": "1.2.1",
"com.unity.burst": "1.8.2",
"com.unity.render-pipelines.core": "12.1.10",
"com.unity.shadergraph": "12.1.10"
"com.unity.burst": "1.8.4",
"com.unity.render-pipelines.core": "14.0.8",
"com.unity.shadergraph": "14.0.8"
}
},
"com.unity.scriptablebuildpipeline": {
"version": "1.20.2",
"version": "1.21.5",
"depth": 0,
"source": "registry",
"dependencies": {},
"url": "https://packages.unity.com"
},
"com.unity.searcher": {
"version": "4.9.1",
"version": "4.9.2",
"depth": 2,
"source": "registry",
"dependencies": {},
"url": "https://packages.unity.com"
},
"com.unity.shadergraph": {
"version": "12.1.10",
"version": "14.0.8",
"depth": 1,
"source": "builtin",
"dependencies": {
"com.unity.render-pipelines.core": "12.1.10",
"com.unity.searcher": "4.9.1"
"com.unity.render-pipelines.core": "14.0.8",
"com.unity.searcher": "4.9.2"
}
},
"com.unity.test-framework": {
Expand Down Expand Up @@ -168,6 +178,12 @@
"dependencies": {},
"hash": "cdd11bb74398afae73e71b6fe01114f597a6ce08"
},
"com.unity.modules.ai": {
"version": "1.0.0",
"depth": 1,
"source": "builtin",
"dependencies": {}
},
"com.unity.modules.animation": {
"version": "1.0.0",
"depth": 0,
Expand Down Expand Up @@ -247,6 +263,12 @@
"com.unity.modules.imageconversion": "1.0.0"
}
},
"com.unity.modules.terrain": {
"version": "1.0.0",
"depth": 2,
"source": "builtin",
"dependencies": {}
},
"com.unity.modules.ui": {
"version": "1.0.0",
"depth": 0,
Expand Down
Loading

0 comments on commit 447679d

Please sign in to comment.