Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix #273; update codestyle doc #274

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

Fix #273; update codestyle doc #274

wants to merge 1 commit into from

Conversation

bates64
Copy link
Collaborator

@bates64 bates64 commented Mar 2, 2018

No description provided.

@bates64 bates64 changed the title Fix #273 Fix #273; update codestyle doc Mar 2, 2018
bates64
bates64 commented Mar 2, 2018
View reviewed changes
CONTRIBUTING.md
function msgTextToEl(text) {
return <div class='Message-content'>
{text}
</div>
Copy link
Collaborator Author

@bates64 bates64 Mar 2, 2018 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

JSX here because then I don't want to have to explain the use of choo/html. Also, we're probably going to switch to Preact sometime soon.

@towerofnix towerofnix added the docs document all the things label Mar 2, 2018
towerofnix
towerofnix reviewed Mar 2, 2018
View reviewed changes
Copy link
Member

@towerofnix towerofnix left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM but not merging until we actually use JSX.

@bates64 bates64 added the blocked Some other issue needs to be resolved before this one can be tackled. label Mar 2, 2018
@bates64 bates64 added the meta Related to this repo, not the code. label Mar 9, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@towerofnix towerofnix towerofnix left review comments

At least 1 approving review is required to merge this pull request.

Assignees
No one assigned
Labels
blocked Some other issue needs to be resolved before this one can be tackled. docs document all the things meta Related to this repo, not the code.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@bates64 @towerofnix